check-meta: defaultCPEParts: accomodate null pname#458529
Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom Nov 4, 2025
Merged
check-meta: defaultCPEParts: accomodate null pname#458529MattSturgeon merged 1 commit intoNixOS:masterfrom
MattSturgeon merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Contributor
Author
|
RossComputerGuy
approved these changes
Nov 4, 2025
MattSturgeon
approved these changes
Nov 4, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Looks like CPE field itself wasn't backported, so this doesn't need backporting after all: #439074 (comment) There's also discussion around postponing until after 25.11: #439074 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnameandversionare sometime specified asnullto get them ignored. If we only check the existence ofpnamewithout checking if it'snull, we'll end up specifyingmeta.cpeParts.product = null.This PR unbreaks
bundlerEnvpassespnameandversionasnulltobuildEnvin case theypnameandversionisn't specified when callingbundlerEnv. In previous implementation,buildEnvonly passespnameandversiondown if they are non-null. To simplify name handling, PR #432957 passesname,pnameandversionas specified tostdenvNoCC.mkDerivationand surface the issue.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.