Open
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
SFrijters
requested review from
K900,
auscyber and
philiptaron
and removed request for
auscyber and
philiptaron
4 tasks
Contributor
|
Also see #434815. cc @ShamrockLee |
ShamrockLee
reviewed
Dec 14, 2025
Comment on lines
+97
to
+108
| env = { | ||
| inherit | ||
| pkgs | ||
| extraPrefix | ||
| ignoreCollisions | ||
| checkCollisionContents | ||
| ignoreSingleFileOutputs | ||
| manifest | ||
| ; | ||
| pathsToLinkJSON = builtins.toJSON pathsToLink; | ||
| extraPathsFrom = toString (lib.optional includeClosures (writeClosure pathsForClosure)); | ||
| }; |
Contributor
There was a problem hiding this comment.
From PR #432957's perspective, referencing from finalAttrs.env.ignoreCollisions is much less intuitive compared to finalAttrs.ignoreCollisions.
In addition, the custom override overrider is prone to be overridden by callPackage-provided <pkg>.override when defining a package, and should be replaced by <pkg>.overrideAttrs. Again, overriding env.ignoreCollisions is less intuitive than overriding ignoreCollisions.
Perl has powerful built-in JSON-parsing support, which we are using to parse chosenOutputs (currently stringified as the pkgs attribute). Why not parsing $NIX_ATTRS_JSON_FILE?
COI disclosure: I'm the author of competing PR:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically moved everything that is referenced in builder.pl via
$ENVinsideenv.Special case:
my $extraPathsFilePath = $ENV{"extraPathsFrom"};is used asopen FILE, $extraPathsFilePath or die "cannot open extra paths file $extraPathsFilePath: $!";, so I assume we can just flatten that withtoString?Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.