corretto25: init at 25.0.1.9.1

[rollf]

This PR adds corretto-25 as a new package using the existing infrastructure for corretto builds.

FYI, my previous corretto-related PR is #459071.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[rollf]

Instead of adding extraNativeBuildInputs, I might as well simply add pandoc to all corretto builds, eventhough it is only used starting at v25. 🤔

[rollf]

The patch is new and added by me (see below). I wonder why the patch is needed, though. I thought the !atLeast23 from here means that the patching is not necessary anymore starting with openJDK 23 and higher. Both openJDK-25 and corretto-25 have disabled format warnings in exactly the same way IMHO. But then, why is it not needed to patch this for jdk25 but for corretto25?

[NyCodeGHG]

Is there a good argument for having corretto packaged in the first place? Are there advantages over upstream OpenJDK?
I think it would be good to reduce our number of JDKs in the long term, rather than increasing it.

[rollf]

Is there a good argument for having corretto packaged in the first place? Are there advantages over upstream OpenJDK? I think it would be good to reduce our number of JDKs in the long term, rather than increasing it.

This topic has been discussed in the past. I have commented on this here (see also my comment just below that one) and here.

I am the maintainer of the corretto package and have contiguously maintained it for >3 years now.

[FliegendeWurst]

I think this needs to be built using Gradle 9. At the moment the build fails with BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 69 (gradle/gradle#35111)

[rollf]

@FliegendeWurst Thank you for looking into this so thoroughly. I am sure it worked previously but I can indeed reproduce this locally now. I wonder what happened in the meantime.

Anyways, indeed only gradle9 supports java25. I have tried to use gradle_9 but run into various problems (Gradle9 seems to be more strict and ans backwards-imcompatible changes it seems). Corretto25 is expected to be build by Gradle 8. I did apply some workarounds and at least it compiles for me right now. I'll have to clean up the mess and check that it actually works. I will update you once this is done.

[rollf]

@FliegendeWurst Thanks for checking, approving & merging!