-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
git: Apply patch to fix uninitialised memory & t8020 test on big-endian #477818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: Apply patch to fix uninitialised memory & t8020 test on big-endian #477818
Conversation
0e9bafd to
b76e477
Compare
|
I'm a bit wary about just suppressing this test: if it's failing, it's failing for a reason. I don't object to having this in place as a temporary workaround, but I'd like someone who has a platform to reproduce the problem to be raising this with the upstream Git community too. Having tests disabled indefinitely makes me sad; having tests disabled with a reference to wherever is tracking/discussing fixing things properly is far preferable from my perspective. |
|
Was already reported & discussed on the Git ML. Agh… grumble grumble mailing lists grumble grumble Will switch to fetching the resulting patch, and send this to staging. |
b76e477 to
a9d41b2
Compare
|
Verified that the fix from the ML fixes the test on ppc64. |
a9d41b2 to
902251d
Compare
|
I'll do a build and tests then merge. Thanks for running this upstream. |
A failure of the t8020-last-modified test on s390x was reported on the mailing list, which uncovered an issue with a
memsetcall in 2.52.0.Apply the patch that resulted from this report. Most immediate result from that is that on big-endian platforms, git-last-modified now behaves correctly again and the t8020-last-modified test suite passes.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.