Skip to content

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jan 7, 2026

A failure of the t8020-last-modified test on s390x was reported on the mailing list, which uncovered an issue with a memset call in 2.52.0.

Apply the patch that resulted from this report. Most immediate result from that is that on big-endian platforms, git-last-modified now behaves correctly again and the t8020-last-modified test suite passes.

Things done

  • Built on platform:
    • x86_64-linux
    • powerpc64-linux (native)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@OPNA2608 OPNA2608 added the 6.topic: exotic Exotic hardware or software platform label Jan 7, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jan 7, 2026
@OPNA2608 OPNA2608 force-pushed the fix/git-ppc64-last-modified-test branch from 0e9bafd to b76e477 Compare January 7, 2026 18:10
@me-and
Copy link
Member

me-and commented Jan 7, 2026

I'm a bit wary about just suppressing this test: if it's failing, it's failing for a reason. I don't object to having this in place as a temporary workaround, but I'd like someone who has a platform to reproduce the problem to be raising this with the upstream Git community too.

Having tests disabled indefinitely makes me sad; having tests disabled with a reference to wherever is tracking/discussing fixing things properly is far preferable from my perspective.

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jan 7, 2026

Was already reported & discussed on the Git ML. Agh… grumble grumble mailing lists grumble grumble

Will switch to fetching the resulting patch, and send this to staging.

@OPNA2608 OPNA2608 marked this pull request as draft January 7, 2026 19:58
@OPNA2608 OPNA2608 force-pushed the fix/git-ppc64-last-modified-test branch from b76e477 to a9d41b2 Compare January 8, 2026 07:39
@OPNA2608 OPNA2608 changed the title git: Disable t8020-last-modified test on ppc64 git: Apply patch to fix uninitialised memory & t8020 test on big-endian Jan 8, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 8, 2026
@OPNA2608 OPNA2608 changed the base branch from master to staging January 8, 2026 07:50
@nixpkgs-ci nixpkgs-ci bot closed this Jan 8, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Jan 8, 2026
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jan 8, 2026

Verified that the fix from the ML fixes the test on ppc64.

@OPNA2608 OPNA2608 marked this pull request as ready for review January 8, 2026 07:55
@OPNA2608 OPNA2608 force-pushed the fix/git-ppc64-last-modified-test branch from a9d41b2 to 902251d Compare January 8, 2026 07:56
@philiptaron
Copy link
Contributor

I'll do a build and tests then merge. Thanks for running this upstream.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 8, 2026
@philiptaron philiptaron added this pull request to the merge queue Jan 8, 2026
Merged via the queue into NixOS:staging with commit 8ab8c3d Jan 8, 2026
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 6.topic: exotic Exotic hardware or software platform 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants