Skip to content

top-level/packages-info: add pname fallback#480323

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther:tarball-pname
Jan 15, 2026
Merged

top-level/packages-info: add pname fallback#480323
wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther:tarball-pname

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Jan 15, 2026

A recent change broke the repology updater, because it relies on pname and version fields. We can fallback to some values temporarily, but the right fix is to make sure pname is available on all packages in Nixpkgs. That effort is ongoing, once it is complete, we should remove the fallbacks.

Fixes #451424 (comment)

Related: repology/repology-updater#1565

Things done

Add a 👍 reaction to pull requests you find important.

@wolfgangwalther
top-level/packages-info: add pname fallback
e19bb69 
A recent change broke the repology updater, because it relies on pname
and version fields. We can fallback to *some* values temporarily, but
the right fix is to make sure pname is available on all packages in
Nixpkgs. That effort is ongoing, once it is complete, we should remove
the fallbacks.
@jopejoe1
Copy link
Member

jopejoe1 commented Jan 15, 2026 •
edited
Loading

Note: name and meta are also currently required by repology's parser so we maybe also want them also to always be set

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 15, 2026
@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Jan 15, 2026

We can probably refactor things, but I believe meta is always set by mkDerivation anyway and name is required by builtins.derivation, so these should always be available anyway.

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Jan 15, 2026

Added a commit to reflect that - tarball creation still passes for me, so should be good.

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Jan 15, 2026

Actually the same is true for system, it is required by builtins derivation. outputName seems to be set on a derivation by default, too - so we can also inherit that unconditionally.

jopejoe1
jopejoe1 approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, linter fails due to formating, but otherwise this looka good to merge for me.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 15, 2026
@wolfgangwalther
top-level/packages-info: inherit name and meta
f928402 
These will always be set on derivations produced by mkDerivation, so no
need for the conditional code paths.
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Jan 15, 2026
Merged via the queue into NixOS:master with commit 7436464 Jan 15, 2026
25 checks passed
@wolfgangwalther wolfgangwalther deleted the tarball-pname branch January 15, 2026 10:48
@AiyionPrime AiyionPrime mentioned this pull request Jan 15, 2026
Closed
@zowoq
Copy link
Contributor

zowoq commented Jan 15, 2026

Thank you!

AiyionPrime added a commit to AiyionPrime/repology-updater that referenced this pull request Jan 17, 2026
@AiyionPrime
Revert "nix_unstable: disable due to broken data (repology#1565)"
0c43d32 
This reverts commit ceb86e4.

This resolves repology#1565 because NixOS/nixpkgs#480323 has been merged as a
workaround to provide pname and version for packages lacking their
explicit definition.
@AiyionPrime AiyionPrime mentioned this pull request Jan 17, 2026
Merged
AMDmi3 pushed a commit to repology/repology-updater that referenced this pull request Jan 19, 2026
@AiyionPrime @AMDmi3
Revert "nix_unstable: disable due to broken data (#1565)"
6cf796c 
This reverts commit ceb86e4.

This resolves #1565 because NixOS/nixpkgs#480323 has been merged as a
workaround to provide pname and version for packages lacking their
explicit definition.
@vcunat
Copy link
Member

vcunat commented Feb 28, 2026 •
edited
Loading

Is there a particular reason why put in these weird values of pname and version instead of using builtins.parseDrvName? (which parses a name into pname + version)

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Mar 2, 2026

Is there a particular reason why put in these weird values of pname and version instead of using builtins.parseDrvName? (which parses a name into pname + version)

I don't think there is a good reason for that, no. Using parseDrvName should be a better fallback indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 approved these changes

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wolfgangwalther @jopejoe1 @zowoq @vcunat