Skip to content

Conversation

@bitbloxhub
Copy link
Contributor

@bitbloxhub bitbloxhub commented Jan 31, 2026

Upstream PR has been sitting for 2 weeks and no other activity on the repo in ~a year.
realthunder/slvs_py#11

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@bitbloxhub
Copy link
Contributor Author

(Should this be backported?)

@nixpkgs-ci nixpkgs-ci bot requested a review from traverseda January 31, 2026 18:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 31, 2026
Copy link
Contributor

@traverseda traverseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately this does

-        cmake_args=['-DENABLE_GUI:BOOL=OFF','-DBUILD_PYTHON:BOOL=ON'],
+        cmake_args=['-DENABLE_GUI:BOOL=OFF','-DBUILD_PYTHON:BOOL=ON', '-DCMAKE_POLICY_VERSION_MINIMUM=3.5'],

which looks good to me

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 31, 2026
@Sigmanificient
Copy link
Member

Related to #445447

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485687
Commit: 4be0a32c68efdd572de879e718cbe633c6c578a6


x86_64-linux

✅ 4 packages built:
  • python313Packages.py-slvs
  • python313Packages.py-slvs.dist
  • python314Packages.py-slvs
  • python314Packages.py-slvs.dist

@Sigmanificient Sigmanificient added this pull request to the merge queue Jan 31, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 31, 2026
Merged via the queue into NixOS:master with commit 6dc9898 Jan 31, 2026
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants