texlive.withPackages: add withDocs, withSources and expose texliveFullWithDocs at top level#497867
texlive.withPackages: add withDocs, withSources and expose texliveFullWithDocs at top level#497867xworld21 wants to merge 2 commits intoNixOS:masterfrom
Conversation
a226a59 to
44c09bd
Compare
|
Even though I've done the last couple of texlive version updates, I'm not actually too familiar with the internals of how the packaging works. Is there some discussion somewhere on deprecating |
chrjabs
left a comment
There was a problem hiding this comment.
Tests (nix-build ../../../../.. -A tests.texlive --no-out-link) and build of texliveFullWithDocs (nix build .#texliveFullWithDocs) pass (on x86_64-linux), so looks good to me.
I have mentioned it a few times since introducing |
Expose new attributes
withDocs,withSourcesthat evaluate to the sametexlive.withPackagesderivation, but withwithDocs = true. I have addedtexliveFullWithDocsat the top level to have Hydra add all texdoc containers to the binary cache.If this gets merged, I think we can finally deprecate
texlive.combinefor good, and start updating the documentation.There's a bit of history around these changes.
I tried to implement
.overrideAttrs { withDocs = true; }quite some time ago (#312945), but it died out, it's just too cumbersome to implement (see also #432957) and it doesn't look like people were clamoring for it..overrideAttrsis also tricky to get right, because some overrides require rebuilding the formats, some don't. It's hard to come up with an overriding mechanism that captures this nicely. Instead,.withDocsis embarrassingly simple to add (and suggests adding.withPaperfor switching defaults between A4 and letter). At any rate, if we manage to implement a version.overrideAttrs { withDocs = true; }, leaving the.withDocsalias is very cheap.The top level
texliveFullWithDocsis odd, but when I tried to have Hydra build all texdoc containers viatexlivePackages, I was told that in fact building each TeX Live package separately causes scheduling issues. I forgot where that conversation was!Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.