etesync-dav: fix web UI for Radicale >= 3.6.0#500192
Open
phaer wants to merge 1 commit intoNixOS:masterfrom
Open
etesync-dav: fix web UI for Radicale >= 3.6.0#500192phaer wants to merge 1 commit intoNixOS:masterfrom
phaer wants to merge 1 commit intoNixOS:masterfrom
Conversation
Radicale 3.6.0 added remote_host and remote_useragent positional arguments to all do_* methods. MyApplication.do_POST and Web.get/post must accept and forward these extra arguments. Proposed for upstreaming in etesync/etesync-dav#365
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spiritual successor to #494473. I hadn't tested login on the web ui manually, and tests don't seem to cover this specific functionality.
Radicale 3.6.0 added remote_host and remote_useragent positional arguments to all do_* methods. MyApplication.do_POST and Web.get/post must accept and forward these extra arguments.
Proposed for upstreaming in etesync/etesync-dav#365
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.