Open
Conversation
| python3, | ||
| }: | ||
|
|
||
| stdenv.mkDerivation rec { |
Member
There was a problem hiding this comment.
Suggested change
| stdenv.mkDerivation rec { | |
| stdenv.mkDerivation (finalAttrs: { |
update to use the finalAttrs pattern (nit, feel free to disregard)
Member
|
jackrosenberg
approved these changes
Apr 18, 2026
Member
jackrosenberg
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
oclgrind, the world's premier OpenCL simulator.This package previously existed in Nixpkgs, but it was removed in #440273 due to incompatibilities with newer versions of LLVM. Now upstream has made a new release and compatibility has been restored. The package in this PR is a trivial update of the last version to be present in Nixpkgs.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.