Skip to content

Revert "rustfmt: 1.0.0 -> 1.0.1"#55437

Merged
timokau merged 1 commit intoNixOS:masterfrom
timokau:rustfmt-revert
Feb 8, 2019
Merged

Revert "rustfmt: 1.0.0 -> 1.0.1"#55437
timokau merged 1 commit intoNixOS:masterfrom
timokau:rustfmt-revert

Conversation

@timokau
Copy link
Member

@timokau timokau commented Feb 8, 2019

Motivation for this change

This reverts commit 7fff567. It depends
on the rustc update I reverted in #55379. It should be re-introduced
after that rustc update has gone through staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This reverts commit 7fff567. It depends
on the rustc update I reverted in NixOS#55379. It should be re-introduced
after that rustc update has gone through staging.
@timokau timokau mentioned this pull request Feb 8, 2019
10 tasks
@GrahamcOfBorg GrahamcOfBorg requested a review from globin February 8, 2019 10:25
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 8, 2019
@timokau timokau merged commit 295acfc into NixOS:master Feb 8, 2019
@timokau timokau deleted the rustfmt-revert branch February 8, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants