Skip to content

deepin.deepin-anything: fix building with linux kernel 5.6 #85883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romildo merged 1 commit into from
May 4, 2020
Merged

deepin.deepin-anything: fix building with linux kernel 5.6 #85883

romildo merged 1 commit into from
May 4, 2020

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Apr 23, 2020 •
edited
Loading

Motivation for this change

Edit:
Fix compilation error and add support to kernel 5.6.
See linuxdeepin/deepin-anything#27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 23, 2020
worldofpeace
worldofpeace reviewed Apr 25, 2020
View reviewed changes
worldofpeace
worldofpeace reviewed Apr 25, 2020
View reviewed changes
@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 25, 2020

@romildo I'm betting stable will be broken?

@romildo
Copy link
Contributor Author

romildo commented Apr 26, 2020

@romildo I'm betting stable will be broken?

It compiles with the default kernel, but fails with boot.kernelPackages = pkgs.linuxPackages_latest.

@romildo
Copy link
Contributor Author

romildo commented May 3, 2020

Can this PR be merged?

@romildo romildo merged commit 44a43c9 into NixOS:master May 4, 2020
@romildo romildo deleted the fix.deepin-anything branch May 4, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@worldofpeace worldofpeace worldofpeace left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romildo @worldofpeace