Change janice_errors.h so there's only one list of errors needed to g…#60
Open
taa01776 wants to merge 5 commits intoNoblis:masterfrom
Open
Change janice_errors.h so there's only one list of errors needed to g…#60taa01776 wants to merge 5 commits intoNoblis:masterfrom
taa01776 wants to merge 5 commits intoNoblis:masterfrom
Conversation
…et enums, string names, and messages
…simple string concatenation
Contributor
Author
|
I notice the shorter-error-list pull request is still pending. |
Better handling of file path in janice_cluster_media
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…et enums, string names, and messages.
Also changed the harness code for registering nonfatal errors to use this. It's kind of an ugly include file hack, but it works to define the enum, an array containing the error names ("JANICE_OUT_OF_MEMORY"), and another array containing the error strings with only one entry of the actual error information.
Not strictly necessary, but I think it makes the error definitions cleaner.