Skip to content

[WIP] Fix artifact building for Windows release#8

Merged
NolanCotter merged 2 commits intomainfrom
copilot/fix-artifact-building-windows
Feb 27, 2026
Merged

[WIP] Fix artifact building for Windows release#8
NolanCotter merged 2 commits intomainfrom
copilot/fix-artifact-building-windows

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 27, 2026

  • Investigate the issue: The "Publish release assets on tag" step is skipped on push-to-main because the if condition only matches tag pushes and workflow_dispatch events (confirmed by run #19 job logs showing step 11 as "skipped")
  • Fix the if condition to also trigger on push to main
  • Fix the tag_name expression to generate a proper dev tag (v0.0.0-dev-{run_number}) for push-to-main events (previously would evaluate to branch name main, not a valid release tag)
  • Fix the prerelease and name expressions for push-to-main scenario
  • Validate YAML syntax
  • Verify expression logic for all trigger scenarios (tag push, workflow_dispatch, push to main, PR, other branches)
  • Run code review
  • Run CodeQL check - no security issues

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

The "Publish release assets" step was skipped on push-to-main because
the if condition only matched tag pushes and workflow_dispatch events.

Changes:
- Add push-to-main to the release step condition
- Fix tag_name to generate dev tag instead of using branch name 'main'
- Simplify prerelease to mark all non-tag releases as pre-releases
- Simplify name to label all non-tag releases with build number

Co-authored-by: ayobro1 <186326284+ayobro1@users.noreply.github.com>
@NolanCotter NolanCotter marked this pull request as ready for review February 27, 2026 18:18
@NolanCotter NolanCotter merged commit 5cec598 into main Feb 27, 2026
1 check passed
Copilot stopped work on behalf of NolanCotter due to an error February 27, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants