Open
Conversation
ameliawalcek
reviewed
Dec 6, 2020
ameliawalcek
left a comment
ameliawalcek
left a comment
There was a problem hiding this comment.
Really nice job, left you some comments
| const cityName = $('#textLine').val() | ||
| if(!cityName) | ||
| return | ||
| model.getCityData(cityName).then(val => view.renderer(val)) |
There was a problem hiding this comment.
try to use async await if you are using it in the rest of the code
|
|
||
| } | ||
|
|
||
| async getDataFromDB(){ |
There was a problem hiding this comment.
I would call this instead getCities that describes better when the method does.
|
|
||
| async saveCity(cityObj){ | ||
| return $.post('/city',cityObj,function(response){ | ||
| console.log(response) |
There was a problem hiding this comment.
use async await here. Keep things consistent
|
|
||
| router.get(`/city/:cityName`,async function(req,res){ | ||
| const cityName = req.params.cityName | ||
| axios.get(`http://api.openweathermap.org/data/2.5/weather?q=${cityName}&appid=561ae52a3ff46bd22a23af0e1667cbf1`) |
There was a problem hiding this comment.
make a .env file to save your keys. Keep your keys safe.
| const cityName = req.params.cityName | ||
| axios.get(`http://api.openweathermap.org/data/2.5/weather?q=${cityName}&appid=561ae52a3ff46bd22a23af0e1667cbf1`) | ||
| .then(function (response) { | ||
| // handle success |
There was a problem hiding this comment.
delete comments when you are finished with your code
| if(err) | ||
| res.send(err) | ||
| else | ||
| res.send("ok") |
There was a problem hiding this comment.
look into HTTP status codes. Try to use those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.