-
Notifications
You must be signed in to change notification settings - Fork 24
noresm3_0_022_cam6_4_121: Use CDEPS for CO2 fossil fuel and aircraft emissions #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noresm3_0_022_cam6_4_121: Use CDEPS for CO2 fossil fuel and aircraft emissions #244
Conversation
|
@mvertens, this command doesn't work |
|
@mvertens Thank you Mariana! I will run a N1850 compset with 2xSSP534 CO2 flux data to see if we can track down the (potential) CO2 conservation issue in CAM |
gold2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have most of co2_cycle.F90 and nudging.F90 to review but here are some items I think should be changed.
src/cpl/nuopc/atm_comp_nuopc.F90
Outdated
| ! Create model_clock as a variable in atm_shr.F90 - needed for generating streams | ||
| model_clock = ESMF_ClockCreate(clock, rc=rc) | ||
| if (ChkErr(rc,__LINE__,u_FILE_u)) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some or all of this should move into atm_shr.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…r.F90 for model_mesh and model_clock
…ised in the PR review
5d1d8c5 to
089444c
Compare
|
@gold2718 - I have removed nudging capability as part of this PR. I have also removed co2_readFlux_ocn from CAM as part of this PR. I think all of the comments above that refer to either of these changes are addressed as part of this removal. |
gold2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this huge effort. I think we need another round of cleanup and many of my comments relate to restoring tintalgo to the namelist for various emission types.
Co-authored-by: goldy <1588651+gold2718@users.noreply.github.com>
gold2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that was a lot of clean. There are still some items on the original list plus maybe one new item. I know that GitHub is making it hard to see some of the comments so I recommented on several.
|
@gold2718 - I think I've addressed all the changes you requested - but it was not always possible for me to respond to the suggestions. I'm happy to address any issues that have not yet been resolved. |
gold2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is finally ready to go, yay!
|
Tagged as |
Summary: Enable fossil fuel and aircraft co2 forcing that are currently on a 2 degree FV grid to be remapped online to the model grid and time interpolated to the model time using CDEPS in-line functionality. The grid mapping is currently hard-wired to be first order conservative.
@adagj @DirkOlivie @tjiputra - the following lists how you can get and use the new code (still in testing)
to get the current branch:
compset and resolution
user_nl_cam
co2flux_fuel_mesh, co2_flux_fuel_year_first, co2_flux_fuel_year_last, co2_flux_fuel_year_alignReviewers: @gold2718
Changes made to build system: None
Changes made to the namelist: The following are new namelist variables:
New namelist
co2_ffuel_nl:New namelist
aircraft_emit_nl:https://escomp.github.io/CDEPS/versions/master/html/index.html
https://escomp.github.io/CDEPS/versions/master/html/streams.html#data-model-stream-inline-api (this is the functionality used in co2_cycle.F90 and co2_data_flux.F90)
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: [ describe or write 'None' ]
Validation:
Testing:
aux_cam_noresmagainst NorESM 3.0 beta09 baseline with only namelist changes due to always having theco2_cycle_nlnamelist inatm_in.