Skip to content

olivia settings #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
monsieuralok wants to merge 3 commits into
base: noresm
Choose a base branch
from
Open

olivia settings #16

monsieuralok wants to merge 3 commits into from
+6 −8

Conversation

@monsieuralok
Copy link

@monsieuralok monsieuralok commented Jan 21, 2026

does not affect reproducibility; crashes happens on Olivia only during DEBUG mode;

@TomasTorsvik TomasTorsvik requested a review from mvertens January 28, 2026 13:21
mvertens
mvertens requested changes Jan 28, 2026
View reviewed changes
src/riverroute/mosart_tspatialunit_type.F90 Outdated
this%twidth(n) = 0._r8
end if
if ( this%tlen(n) > 0._r8) then
if ( this%tlen(n) > 0._r8 .and. &
Copy link

@mvertens mvertens Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please remove the this%tlen(n) > 0._r8 .and. here since it is redundant with the line above.

Copy link
Collaborator

@mvdebolskiy mvdebolskiy Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 1ac3d6e

@github-project-automation github-project-automation bot moved this from Todo to In Progress in NorESM Development Jan 28, 2026
@mvdebolskiy mvdebolskiy self-requested a review January 28, 2026 13:24
@mvertens
Copy link

mvertens commented Jan 28, 2026 •
edited
Loading

@monsieuralok - if you get a chance could you also remove the following lines from mosart_restartfile..F90

               if (flag == 'read') then
                  write(6,*)'DEBUG: reading in restart for '//trim(vname)
               end if

This gives a lot of extra output that is not needed in the cesm.log files.

@monsieuralok
Copy link
Author

monsieuralok commented Jan 28, 2026

@mvertens @TomasTorsvik done we can merge it.

@TomasTorsvik TomasTorsvik self-requested a review January 28, 2026 14:16
@TomasTorsvik TomasTorsvik added this to the noresm3.0 milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvertens mvertens mvertens requested changes

@TomasTorsvik TomasTorsvik TomasTorsvik approved these changes

@mvdebolskiy mvdebolskiy Awaiting requested review from mvdebolskiy

Requested changes must be addressed to merge this pull request.

Assignees

@monsieuralok monsieuralok

Labels

None yet

Projects

NorESM Development
Status: In Progress

Milestone

noresm3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monsieuralok @mvertens @TomasTorsvik @mvdebolskiy