Skip to content

Tweaks to ModResources helpers, Story.cs #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LaughingLeader wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tweaks to ModResources helpers, Story.cs #91

LaughingLeader wants to merge 4 commits into from

Conversation

@LaughingLeader
Copy link
Contributor

@LaughingLeader LaughingLeader commented Jul 9, 2022 •
edited
Loading

This is mainly tweaks to ModResources functions for package discovery, with a few extras for Story.FindBuiltinTypeId issues in certain contexts.

Changes Commit(s)
Check that the Public folder exists before parsing it 06e4168
Support parsing paks ending in _number.pak, that aren't partial paks, in DiscoverBuiltinPackages and DiscoverUserPackages fc3f218
Allow pak loading to fail in the discover helpers, and output the exception to the console/etc 9fda95a
Add a filepath parameter to NotAPackageException, which is printed in the exception abfde2c
Add an .editorconfig that specifies that the solution uses spaces for indentation, so Visual Studio plays nice 08574d1 882666f
Update CommandLineArgumentsParser, Newtonsoft.Json, and Google.Protobuf ae38b64

@LaughingLeader LaughingLeader force-pushed the helper-tweaks branch 2 times, most recently from 96f0b18 to a6e5734 Compare July 11, 2022 19:47
@LaughingLeader
Implement various tweaks to improve pak discovery
65bcdab 
Wrap package reading in a try/catch block, allow exceptions to print for pak loading errors
Add a fileName parameter to NotAPackageException
Rework package discovery to allow paks that end in an underscore + number
Fix for missing builtin types in some compiler contexts
Check that public path exists before parsing it
@LaughingLeader
Add editor config to specify that indents use spaces
0d72caf
@LaughingLeader
Update packages
3b0b665
3Ring pushed a commit to 3Ring/lslib that referenced this pull request Nov 6, 2023
@NellsRelo
Merge pull request Norbyte#91 from BG3-Community-Library-Team/ScriptF…
9c8761b 
…ixes

Minor tweaks to khn files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LaughingLeader