Add datacenterlist and clusterlistitem views#269
Merged
havardelnan merged 5 commits intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new view generators to expose datacenter listings and a “single cluster item” view via the existing /v2/views/{viewid} list-view mechanism, with cluster selection driven by a filter parameter.
Changes:
- Added
datacenterlistview generator producing a list of datacenter rows. - Added
clusterlistitemview generator intended to return a single cluster row when filtered byclusterUid. - Minor swagger annotation formatting adjustment in the list view handler.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| pkg/services/viewservice/datacenterlist.go | Introduces a new list-view generator for datacenters backed by ResourceDatacenterGVK. |
| pkg/services/viewservice/clusterlistitem.go | Introduces a new list-view generator intended to return one cluster based on a clusterUid filter. |
| internal/controllers/v2/viewcontroller/listviewhandler.go | Aligns swagger annotation formatting for the limit query parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
havardelnan
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement views for datacenters and a single cluster item, following the pattern of the other views. A single cluster can now be fetched by adding a filter to the api call, with the clusterUid.