Added timer_isActive() #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a public function timer_isActive() to expose timer active status checking functionality. The codebase already has an internal function _is_timer_active() that performs this check, and this new function aims to provide the same capability through the public API.
Key changes:
- Added
timer_isActive()function declaration to the header file with appropriate documentation - Implemented
timer_isActive()in the source file to check timer active status viatx_timer_info_get()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| threadX/inc/u_tx_timers.h | Adds public API function declaration with @brief documentation |
| threadX/src/u_tx_timers.c | Implements timer active status checking, but contains a critical variable shadowing bug and copy-pasted comments that need correction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jr1221
previously approved these changes
Nov 24, 2025
jr1221
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to
u_tx_timers.cthat checks whether or not a timer is active.