Skip to content

Conversation

@suryatho
Copy link

@suryatho suryatho commented Dec 8, 2025

Changes

Send delta between min and max voltages over segment

Notes

my format on save is messing with stuff should I undo those changes ?

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@suryatho suryatho linked an issue Dec 8, 2025 that may be closed by this pull request
@suryatho
Copy link
Author

suryatho commented Dec 8, 2025

I ran clang format using the format file in embedded base because i was getting reprimanded by the linter workflow but that ended up changing the whole codebase so lmk what i should rollback.

Also the segment_total_volts wasn't being calculated anywhere so i added that in (was I supposed to)?

Another question. how do i make my lsp work ? theres always a red squiggly because it doesn't know about some header file somewhere. I tried just telling it to find anything with inc or include but that didn't really work how i wanted it to

should i be cloning recursively or do i not actually have to?

Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @suryatho . I made this PR just to update your branch to latest version of the codebase since some changes were made #41, if you can just look this over and then merge the PR into your branch, that would be great. I fixed some formatting as well and thank you for adding in that function to send the delta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add segment delta & can message

3 participants