Attempted refactor to download class #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NotJoeMartinez merged 2 commits into main from attempted_refactor_to_download_class

Jun 29, 2024

Owner

NotJoeMartinez commented Jun 29, 2024

Tried refactor the download.py module into OOP
Realized that this could break too many unknown things unless we have unit good testing
moved handle_reject_consent_cookie to utils
moved get_channel_id_from_input to db_utils
added more details to testing document

NotJoeMartinez added 2 commits

June 25, 2024 21:15


          moved cookie handler, mapped out downloads

ec37bc3


          get_channel_name_from_video_id -> utils.py, testing

148788b

NotJoeMartinez merged commit 50a9fae into main

6 checks passed

NotJoeMartinez deleted the attempted_refactor_to_download_class branch

June 29, 2024 03:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet