Skip to content

Conversation

@Nowely
Copy link
Owner

@Nowely Nowely commented Nov 18, 2025

Summary

  • Updated ESLint rules in .oxlintrc.json to disable overly strict accessibility and testing checks while enforcing stricter type import conventions
  • Refactored imports across 70+ files to use type keyword for type-only imports, improving type safety and clarity
  • Reorganized code structure by extracting processTokensWithCallback into a dedicated utility file
  • Suppressed legitimate ESLint warnings with explanatory comments (e.g., import cycles in recursive components)
  • Improved test organization by using it.todo() for pending tests

Key Changes

  1. Linting Configuration: Disabled jsx_a11y/click-events-have-key-events, jest/valid-expect, and react/exhaustive-deps rules while enforcing typescript/consistent-type-imports and import/no-cycle
  2. Type Imports: Enforced consistent use of type keyword across all package imports for better tree-shaking and clarity
  3. Code Refactoring: Moved token processing logic to utils/processTokens.ts for better organization
  4. Type Safety: Enhanced EventKey interface and other type definitions to align with linting standards
  5. Test Improvements: Refactored test cases and removed unnecessary Vitest references

Benefits

  • Improved code consistency and maintainability
  • Better type safety through explicit type imports
  • Clearer separation of type and value imports for better bundling
  • More organized utility structure
  • Better test clarity with explicit pending test markers

…change imports to use 'type' for better type safety in multiple files.
… rule in .oxlintrc.json and update imports to use 'type' for various components across the codebase.
…unction to a new file for better organization and clarity. Update imports accordingly.
…s in Piece and Token components, clarifying the legitimate recursive relationship between them.
…ead of useStore, improving clarity and reducing unnecessary imports.
…ark component. Added a check to confirm that the root mark has children, improving test coverage for nested content rendering.
…stive-deps" rules, enhancing flexibility in testing and dependency management.
…ts" rule, allowing for more flexibility in accessibility checks. Remove Vitest reference from stories.spec.tsx for cleaner test setup.
…r for improved clarity. Remove Vitest reference from MarkedInputHandler.spec.tsx for cleaner test setup.
…improving clarity on unimplemented functionality.
@vercel
Copy link

vercel bot commented Nov 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marked-input Ready Ready Preview Comment Nov 18, 2025 11:13am

…MarkupDescriptor for improved code consistency.
@Nowely Nowely merged commit 15adebe into next Nov 18, 2025
7 checks passed
@Nowely Nowely deleted the lint branch November 18, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants