fix(command): improve command handling for non-player senders and rel… #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oad permissions Closes #12
There was a problem hiding this comment.
Pull Request Overview
This PR improves command handling for non-player senders by providing tailored help messages and adjusting permission checks for reload commands.
- Non-player senders now receive a different help message when no arguments are provided.
- The "channel" command now verifies the sender is a player before execution.
- The reload command has been modified to accept a CommandSender and conditionally perform permission checks.
| case "reload" -> handleReloadCommand(player); | ||
| default -> sendHelpMessage(player); | ||
| case "channel", "ch" -> { | ||
| if (!(sender instanceof Player player)) { |
There was a problem hiding this comment.
[nitpick] The instance-of check for Player is repeated in several branches. Consider refactoring this pattern into a helper method to reduce duplication and improve maintainability.
Suggested change
| if (!(sender instanceof Player player)) { | |
| Player player = isPlayerSender(sender); | |
| if (player == null) { |
| private void handleReloadCommand(Player player) { | ||
| if (!player.hasPermission("remmychat.admin")) { | ||
| private void handleReloadCommand(CommandSender sender) { | ||
| if (sender instanceof Player player && !player.hasPermission("remmychat.admin")) { |
There was a problem hiding this comment.
[nitpick] Since non-player senders bypass the permission check in handleReloadCommand, consider adding an inline comment to clarify that console or other non-player senders are intended to bypass this check.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oad permissions
Closes #12