-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Enhance MCTS hybrid search features #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
|
bugbot run |
Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| _CMAKE_CXX_LINKER_PUSHPOP_STATE_SUPPORTED:INTERNAL=TRUE | ||
| //linker supports push/pop state | ||
| _CMAKE_LINKER_PUSHPOP_STATE_SUPPORTED:INTERNAL=TRUE | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build artifacts accidentally committed to repository
Medium Severity
The entire _codeql_build_dir/ directory containing CMake build artifacts from a CodeQL analysis run has been committed. These auto-generated files include CMakeCache.txt, Makefiles, dependency info, and configuration logs with hardcoded absolute paths to the CI runner environment (/home/runner/work/MetalFish/...). Build directories should be added to .gitignore, not version control.
Additional Locations (2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an LTO (Link-Time Optimization) linking error by converting GPUTuningParams::select_strategy() from an out-of-line member function to an inline member function defined directly in the header file.
Changes:
- Moved implementation of
select_strategy()into the header as an inline function - Removed the corresponding implementation from the
.cppfile
Reviewed changes
Copilot reviewed 33 out of 35 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gpu/gpu_nnue_integration.h | Defines select_strategy() as inline with implementation in header |
| src/gpu/gpu_nnue_integration.cpp | Removes out-of-line implementation of select_strategy() |
| _codeql_detected_source_root | Adds CodeQL source root marker |
| _codeql_build_dir/* | Build system generated files from CodeQL analysis |
GPUTuningParams::select_strategy()by making it inline in the header💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Note
Introduces generated CMake artifacts to document a successful CodeQL build.
_codeql_build_dircontainingCMakeCache.txt,CMakeConfigureLog.yaml, makefiles, progress files, and dependency infometalfishandmetalfish_testswith LTO enabledWritten by Cursor Bugbot for commit 669b3df. This will update automatically on new commits. Configure here.