Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 24, 2026

  • Fix LTO linking error for GPUTuningParams::select_strategy() by making it inline in the header
  • Verify the fix builds successfully
  • Reply to the comment with the fix

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.


Note

Introduces generated CMake artifacts to document a successful CodeQL build.

  • Adds _codeql_build_dir containing CMakeCache.txt, CMakeConfigureLog.yaml, makefiles, progress files, and dependency info
  • Confirms compiler/linker config and successful build of metalfish and metalfish_tests with LTO enabled

Written by Cursor Bugbot for commit 669b3df. This will update automatically on new commits. Configure here.

Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
@NripeshN
Copy link
Owner

bugbot run

Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@NripeshN NripeshN marked this pull request as ready for review January 24, 2026 15:01
Copilot AI review requested due to automatic review settings January 24, 2026 15:01
@NripeshN NripeshN merged commit d4e7740 into hybrid-and-mcts-fix Jan 24, 2026
@NripeshN NripeshN deleted the copilot/sub-pr-8-yet-again branch January 24, 2026 15:02
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

_CMAKE_CXX_LINKER_PUSHPOP_STATE_SUPPORTED:INTERNAL=TRUE
//linker supports push/pop state
_CMAKE_LINKER_PUSHPOP_STATE_SUPPORTED:INTERNAL=TRUE

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build artifacts accidentally committed to repository

Medium Severity

The entire _codeql_build_dir/ directory containing CMake build artifacts from a CodeQL analysis run has been committed. These auto-generated files include CMakeCache.txt, Makefiles, dependency info, and configuration logs with hardcoded absolute paths to the CI runner environment (/home/runner/work/MetalFish/...). Build directories should be added to .gitignore, not version control.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an LTO (Link-Time Optimization) linking error by converting GPUTuningParams::select_strategy() from an out-of-line member function to an inline member function defined directly in the header file.

Changes:

  • Moved implementation of select_strategy() into the header as an inline function
  • Removed the corresponding implementation from the .cpp file

Reviewed changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated no comments.

File Description
src/gpu/gpu_nnue_integration.h Defines select_strategy() as inline with implementation in header
src/gpu/gpu_nnue_integration.cpp Removes out-of-line implementation of select_strategy()
_codeql_detected_source_root Adds CodeQL source root marker
_codeql_build_dir/* Build system generated files from CodeQL analysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants