Design: Sort packages.lock.json dependencies by name#14763
Open
apoorvdarshan wants to merge 1 commit intoNuGet:devfrom
Open
Design: Sort packages.lock.json dependencies by name#14763apoorvdarshan wants to merge 1 commit intoNuGet:devfrom
apoorvdarshan wants to merge 1 commit intoNuGet:devfrom
Conversation
Proposes adding alphabetical sorting by package name as a secondary sort key when generating packages.lock.json, reducing diff churn during CPM migration and ensuring deterministic ordering. Addresses NuGet#14115
dotnet-policy-service
bot
added
the
Community
dotnet-policy-service
bot
added
the
Status:No recent activity
Contributor
|
This PR has been automatically marked as stale because it has no activity for 30 days. It will be closed if no further activity occurs within another 330 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages.lock.json.ThenBy(d => d.Id, StringComparer.OrdinalIgnoreCase)inPackagesLockFileBuilder.csTest plan
PackagesLockFileFormatTestspass with the ordering changeIsLockFileStillValid()is unaffected since it uses dictionary lookups, not list orderAddresses #14115