Skip to content

[Feature] Implement Support for NuGet Authentication Plugins as .NET Tools#6177

Merged
Nigusu-Allehu merged 5 commits intodevfrom
dev-feature-dot-net-tool-plugin-support
Dec 2, 2024
Merged

[Feature] Implement Support for NuGet Authentication Plugins as .NET Tools#6177
Nigusu-Allehu merged 5 commits intodevfrom
dev-feature-dot-net-tool-plugin-support

Conversation

@Nigusu-Allehu
Copy link
Copy Markdown
Member

@Nigusu-Allehu Nigusu-Allehu commented Nov 28, 2024

Bug

Fixes:

Description

ReApply #6138. It was reverted because of a bug. The bug has been addressed in #6173

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner November 28, 2024 22:27
@Nigusu-Allehu Nigusu-Allehu self-assigned this Nov 28, 2024
Copy link
Copy Markdown
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think next time you should just revert the revert in dev, commit a fix, and push that as a branch. This is sort of confusing that its coming from a feature branch that was already merged. The last commit shows the fix but I think its cleaner to just revert the revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants