Remove IsDesktop & Add PluginFile PluginFile(filePath, state) constructor

[Nigusu-Allehu]

Bug

Fixes: NuGet/Home#13975

Addresses comments regarding renaming variables and refactoring test in #6138

Description

Remove IsDesktop & Add PluginFile PluginFile(filePath, state) contractor

PR Checklist

• Meaningful title, helpful description and a linked NuGet/Home issue
• Added tests
• Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

[nkolev92]

PR Naming:
The PR title should say what the PR does, more so than the why.
The issue covers the why.

[nkolev92]

I think you need to flip the condition during the rename.

[Nigusu-Allehu]

I think you need to flip the condition during the rename.

Yes that is correct! I think this got a bit confusing because I did not do that. I have also re written the description to make this clearer

[jeffkl]

@Nigusu-Allehu and I spoke offline and thought it would be better to just get rid of IsDesktop/RequiresDotNetHost in favor of a new constructor that does the same thing. It allows a decent amount of duplicated code to be removed and is cleaner in my opinion.

[jebriede]

@Nigusu-Allehu and I spoke offline and thought it would be better to just get rid of IsDesktop/RequiresDotNetHost in favor of a new constructor that does the same thing. It allows a decent amount of duplicated code to be removed and is cleaner in my opinion.

This is great! @Nigusu-Allehu can we rename the title of this PR to reflect this update? Currently it says that we are renaming IsDesktop to RequiresDotNetHost, but the change is more than just renaming the variable now.

[jebriede]

Please update the title of the PR to reflect the updated changes. The code changes LGTM! 🚀