Skip to content

Update vulnerabilities infobar text to invoke Copilot#7206

Closed
martinrrm wants to merge 1 commit intodevfrom
dev-martinrm-update-fix-text
Closed

Update vulnerabilities infobar text to invoke Copilot#7206
martinrrm wants to merge 1 commit intodevfrom
dev-martinrm-update-fix-text

Conversation

@martinrrm
Copy link
Copy Markdown
Contributor

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/3587

Description

Update infobar to the recommended text

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • [ ] Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@martinrrm martinrrm requested a review from a team as a code owner March 10, 2026 23:11
@jebriede
Copy link
Copy Markdown
Contributor

@martinrrm can you add a screenshot of what this looks like?

<data name="InfoBar_HyperlinkFixVulnerabilitiesWithCopilot" xml:space="preserve">
<value>Fix with GitHub Copilot</value>
<comment>Do not translate GitHub or Copilot</comment>
<value>Fix</value>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request asks for updated wording and for a sparkle icon to appear next to “Fix.” I only see .resx changes in this PR, so it appears to update the wording only and does not introduce the icon next to or as part of the hyperlink. Is that correct?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The infobar doesn't accept monikers inside the text, I wasn't able to get the suggested sparkle icon just this using /u2726, what do you suggest we should do?

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked offline. What we discussed:

  • The first step is to investigate if the InfoBar can support an image or custom XAML.
  • If not, file an issue against the InfoBar APIs and link it as a blocker for this issue.

The wording should be updated only when the sparkle icon can be added to the hyperlink.

@martinrrm martinrrm requested a review from jebriede March 13, 2026 19:26
@martinrrm martinrrm marked this pull request as draft March 16, 2026 16:56
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Mar 23, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants