Add ability to disable the writing of the dependency graph spec file#7239
Open
Add ability to disable the writing of the dependency graph spec file#7239
Conversation
nkolev92
reviewed
Mar 27, 2026
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/NoOpRestoreUtilities.cs
Outdated
Show resolved
Hide resolved
| private static readonly byte[] SdkAnalysisLevel = Encoding.UTF8.GetBytes("SdkAnalysisLevel"); | ||
| private static readonly byte[] UsingMicrosoftNETSdk = Encoding.UTF8.GetBytes("UsingMicrosoftNETSdk"); | ||
| private static readonly byte[] UseLegacyDependencyResolverPropertyName = Encoding.UTF8.GetBytes("restoreUseLegacyDependencyResolver"); | ||
| private static readonly byte[] RestoreDoNotWriteDependencyGraphSpecPropertyName = Encoding.UTF8.GetBytes("restoreDoNotWriteDependencyGraphSpec"); |
Member
There was a problem hiding this comment.
I wonder if this should be a part of the no-op invalidation.
Like in theory, if I went from no to yes, I'd want the dgspec to be regenerated, but I know there's been attempts at using CI data to make local restores more efficient.
My only concern with not adding it though is it becoming out of date.
Contributor
Author
There was a problem hiding this comment.
Yeah I was worried about special casing any particular property, just in case that little detail is lost in the overall design. I could go either way...
|
nit: The property in the PR description has a typo of Sepc instead of Spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14114
Description
This will allow users to disable the writing of the DGSpec file since for large restores it can add a measurable amount of overhead. The guidance would be to only enable this option in a hosted build environment like:
PR Checklist