Remove admin elevation requirement from signed package tests#7241
Open
Remove admin elevation requirement from signed package tests#7241
Conversation
dtivel
force-pushed
the
dtivel/remove-elevation-requirement
branch
3 times, most recently
from
7b3b0c6 to
afefea5
Compare
dtivel
force-pushed
the
dtivel/remove-elevation-requirement
branch
from
afefea5 to
5a3d99f
Compare
nkolev92
added
the
Engineering
Member
We have changed our process for engineering issues fix on the fly. If there's no issue created, no need to create a new one, we just tag the PR with Engineering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: TBD
Description
This PR enables in-memory trust stores on Windows for .NET 5+ by removing two platform gates in test infrastructure. Change
[CIOnlyFact]/[CIOnlyTheory]to[Fact]/[Theory]so signing tests run on developer machines without elevation.There are no product code changes.
PR Checklist
[ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.CC @zivkan, @nkolev92. Did you already have an issue for this or shall I create one?