Skip to content

Change protected overload of PackageManager.InstallPackage to be public #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glennblock wants to merge 2 commits into
base: 2.13
Choose a base branch
from
Open

Change protected overload of PackageManager.InstallPackage to be public #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eb98d2
Make protected InstallPackage method public.
glennblock Feb 16, 2017
98a46f8
Adds new overload for InstallPackage
glennblock Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/IPackageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface IPackageManager
event EventHandler<PackageOperationEventArgs> PackageInstalling;
event EventHandler<PackageOperationEventArgs> PackageUninstalled;
event EventHandler<PackageOperationEventArgs> PackageUninstalling;

void InstallPackage(IPackage package,FrameworkName targetFramework,bool ignoreDependencies,bool allowPrereleaseVersions,bool ignoreWalkInfo = false)
void InstallPackage(IPackage package, bool ignoreDependencies, bool allowPrereleaseVersions);
void InstallPackage(IPackage package, bool ignoreDependencies, bool allowPrereleaseVersions, bool ignoreWalkInfo);
void InstallPackage(string packageId, SemanticVersion version, bool ignoreDependencies, bool allowPrereleaseVersions);
Expand Down
4 changes: 2 additions & 2 deletions src/Core/PackageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public void InstallPackage(IPackage package, bool ignoreDependencies, bool allow
InstallPackage(package, targetFramework: null, ignoreDependencies: ignoreDependencies, allowPrereleaseVersions: allowPrereleaseVersions, ignoreWalkInfo: ignoreWalkInfo);
}

protected void InstallPackage(
public void InstallPackage(
IPackage package,
FrameworkName targetFramework,
bool ignoreDependencies,
Expand Down Expand Up @@ -485,4 +485,4 @@ public void UpdatePackage(IPackage newPackage, bool updateDependencies, bool all

public bool CheckDowngrade { get; set; }
}
}
}