Fix tab flicker when changing package versions by preventing content flash during tab restoration#10565
Draft
Fix tab flicker when changing package versions by preventing content flash during tab restoration#10565
Conversation
Contributor
|
@copilot , try again |
…isibility when localStorage preference differs from default Co-authored-by: skofman1 <16807822+skofman1@users.noreply.github.com>
Contributor
Author
I've implemented a fix for the tab flicker issue. The problem was that when changing package versions, the server always renders the README tab as active by default, but then JavaScript restores the user's preferred tab from localStorage, causing a visual flicker. My solution works by:
This prevents the flicker by ensuring users don't see the README tab content briefly before switching to their preferred tab (like Versions). The fix is in commit 2a38e2d and only modifies the JavaScript file |
…ardcoding README tab check Co-authored-by: skofman1 <16807822+skofman1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [NuGet.org Bug]: Changing selected Version briefly flickers to the README tab
Fix tab flicker when changing package versions by preventing content flash during tab restoration
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9985
When navigating between different versions of a package (e.g., from
/packages/Newtonsoft.Json/13.0.2to/packages/Newtonsoft.Json/13.0.1), users experienced a brief flicker where the README tab content would flash before switching to their preferred tab (like Versions).Root Cause
The issue occurred because:
Solution
Modified
page-display-package.jsto prevent the flicker by:visibility: hidden#readme-body-tab)The fix is surgical - only ~15 lines of JavaScript added - and handles edge cases like missing localStorage, URL fragments, and packages with different default tabs.
Testing
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.