Add note for .NET tool dependencies (#10020)#10736
Add note for .NET tool dependencies (#10020)#10736abdulrahmanhossam wants to merge 2 commits intoNuGet:devfrom
Conversation
|
Hi @joelverhagen, thanks for the assignment! 🚀 I've updated the base branch to Here is a mockup screenshot of how the UI will look with the proposed changes: I'm totally open to any feedback on the wording or implementation from the team! Let me know what you think. |
|
Thank you for the contribution @abdulrahmanhossam! 🎉 One small suggestion on the wording, instead of "See this issue to vote and improve this experience", how about: .NET tools have dependencies embedded in the package. Join the discussion on improving this experience. This sets the right expectation for users clicking through. |
|
Makes sense (still funny that I'm the only one who has upvoted the issue in two years 😅) |
|
Thanks for the feedback, @pranathibora14! That wording definitely makes more sense. I've just pushed a commit to update the message as suggested. Let me know if there's anything else needed! |

Fixes #10020
Description
Updated the
DependencySetsViewModelandDisplayPackageViewModelFactoryto pass theIsDotnetToolflag.Modified
_PackageDependencies.cshtmlto display a note with a link to issue #10020 when a package is a .NET Tool and has no explicit dependencies in its nuspec.Expected Behavior
Instead of showing "This package has no dependencies.", .NET tools will now show: ".NET tools have dependencies embedded in the package." along with a link to gather upvotes for improving the experience.