Support for multiple destinations for GitHubVulnerabilities2v3 job#10741
Open
Support for multiple destinations for GitHubVulnerabilities2v3 job#10741
Conversation
Multiple ingestor collection.
zhhyu
reviewed
Mar 23, 2026
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; |
Contributor
There was a problem hiding this comment.
nit: some dependencies may be not needed.
zhhyu
reviewed
Mar 23, 2026
| using NuGet.Services.GitHub.Ingest; | ||
| using Microsoft.Extensions.Logging; | ||
| using NuGet.Services.Cursor; | ||
| using System.Collections.Generic; |
Contributor
There was a problem hiding this comment.
nit: order of dependencies.
zhhyu
previously approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on https://github.com/NuGet/Engineering/issues/6293, #10656
Adds support for multiple ingestors to
AdvisoryCollector. Replaced singleIAdvisoryIngestorconstructor argument withIReadOnlyCollection<IAdvisoryIngestor>. DI container takes care of creating a list of registrations.Added support to specify more than one blob storage destination for the job. Only 1 or 2 destinations are supported at the moment, as I don't see a need for more, but the code is easily updatable to accommodate. Job configuration file is changed as a result: removed
StorageConnectionStringandV3BaseUrlproperties, introducedDestinationsarray property instead that is expected to contain a list (of 1 or 2 elements) of objects containing the properties removed from the configuration object.Job configuration would have to be updated with this change.
Added tests for
AdvisoryCollector.