Update NU1703 doc to reflect new monoandroid warning#3542
Update NU1703 doc to reflect new monoandroid warning#3542sbomer wants to merge 5 commits intoNuGet:mainfrom
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit df60919: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
Adds documentation for the newly introduced NU1704 warning, and links it from the existing errors/warnings reference index so users can discover and understand the warning.
Changes:
- Add a new reference page documenting warning NU1704, including cause, conditions, and suppression guidance.
- Update the errors/warnings index table to include a link to NU1704.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docs/reference/errors-and-warnings/NU1704.md |
New documentation page describing NU1704, its trigger conditions, and mitigation/suppression guidance. |
docs/reference/Errors-and-Warnings.md |
Adds NU1704 to the “Package fallback warnings” row so it’s linked from the index. |
| --- | ||
|
|
||
| # NuGet Warning NU1704 | ||
|
|
||
| > Package 'packageId' version uses the deprecated MonoAndroid framework instead of 'net6.0-android' or later. Consider upgrading to a newer version of this package or contacting the package author. |
There was a problem hiding this comment.
The quoted warning text reads awkwardly/incorrectly: "Package 'packageId' version uses..." (it looks like the version value is missing). Update the message to either include the version placeholder/value or rephrase to remove "version" so the sentence is grammatically correct and matches the actual NU1704 warning output.
| --- | |
| # NuGet Warning NU1704 | |
| > Package 'packageId' version uses the deprecated MonoAndroid framework instead of 'net6.0-android' or later. Consider upgrading to a newer version of this package or contacting the package author. | |
| ai-usage: ai-generated | |
| --- | |
| # NuGet Warning NU1704 | |
| > Package 'packageId' version 'version' uses the deprecated MonoAndroid framework instead of 'net6.0-android' or later. Consider upgrading to a newer version of this package or contacting the package author. |
|
This part from the implementation PR seems to not be covered
Does that mean it will only show up if you use lockfiles? |
|
Due to historical reasons the type "LockFile" is the one that represents the assets file. So it'd be a massive breaking change to change that now, so often times people may refer to lock files, but they really mean the assets file. |
|
Ah I see, thanks for the explanation! |
Per PR feedback on NuGet/NuGet.Client#7229, reuse the NU1703 warning code for the MonoAndroid deprecation scenario. The previous NU1703 for Xamarin.iOS never shipped, so the code is safe to repurpose. Remove NU1704 doc and references from TOC and index.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit ea200b3: 💡 Validation status: suggestions
docs/reference/errors-and-warnings/NU1703.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit a8660b2: ✅ Validation status: passed
For more details, please refer to the build report. |
Adds documentation for the warning added in NuGet/NuGet.Client#7229.