Resolving Svelte binding warnings#784
Merged
plural merged 3 commits intoNull-Signal-Games:mainfrom May 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes should resolve the massive amount of binding warnings being generated by the tests.
These warnings were being generated because the
bind:directive cannot be used with derived variables and bindable props. The best solution I've found for this is to create local copies of editable entities that can be bound to.I have some thoughts about how to improve the bindings and callbacks that we're currently using but I need to play around with those more before making any changes.
As part of this, I also updated
TournamentSettingsFormto use the newProgressButtonfor consistency and because theisSubmittingprop was tangled with these changes. I needed to remove two tests that were specifically testing that the save button on that component was disabled when clicked due to the way theProgressButtonworks - I assume this is low priority and we can figure out a better way to test that sort of thing later.