CompatHelper: bump compat for Thermodynamics to 1, (keep existing compat)#116
Open
github-actions[bot] wants to merge 3 commits intomainfrom
Open
CompatHelper: bump compat for Thermodynamics to 1, (keep existing compat)#116github-actions[bot] wants to merge 3 commits intomainfrom
github-actions[bot] wants to merge 3 commits intomainfrom
Conversation
navidcy
added
dependencies 🖇️
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
navidcy
reviewed
Mar 13, 2026
Member
navidcy
left a comment
navidcy
left a comment
There was a problem hiding this comment.
@simone-silvestri do you know if Thermodynamics v1 includes breaking changes we should take action before adding the compat?
Member
|
There should be but I thought we accounted for them correclty. I would say, let's merge this |
simone-silvestri
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Thermodynamicspackage from0.15.3to0.15.3, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.