Revert CATKE mixing length to calibrated default#166
Open
simone-silvestri wants to merge 1 commit intomainfrom
Open
Revert CATKE mixing length to calibrated default#166simone-silvestri wants to merge 1 commit intomainfrom
simone-silvestri wants to merge 1 commit intomainfrom
Conversation
Remove the ad-hoc override CATKEMixingLength(Cᵇ=0.01) and use the published calibrated default from Wagner et al. (2025). The parameter Cᵇ controls the bottom-distance constraint on the stable mixing length: ℓ = min(Cˢ·d_surface, Cᵇ·d_bottom, w★/√N²). With Cᵇ=0.01 (28× smaller than the calibrated 0.28), the bottom term dominates for all depths below ~50 m and caps the mixing length at roughly 50 m regardless of how much TKE is available. This severely limits the vertical diffusivity κ = ℓ·√e throughout the water column, producing unrealistically shallow mixed layer depths globally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
BTW I am not sure this is a fix because the deep mixed layers are produced by convection while this parameter only touches the shear mixing length in stable conditions. However, I will test it out and report back |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CATKEMixingLength(Cᵇ=0.01)indefault_ocean_closure()and use the published calibrated default (Cᵇ=0.28, Wagner et al. 2025).Motivation
The parameter
Cᵇcontrols the bottom-distance constraint on the CATKE stable mixing length:With
Cᵇ = 0.01(28× smaller than the calibrated value of 0.28), the bottom term becomes the tightest constraint for nearly all depths below ~50 m, regardless of ocean depth. In a 5 km deep ocean:Cˢ × d_upCᵇ × d_down(0.01)Cᵇ × d_down(0.28)This artificially caps the mixing length at ~50 m everywhere, directly suppressing the vertical diffusivity
κ = ℓ × √eand producing unrealistically shallow mixed layer depths globally.Below are the MLD diagnostics from an 8-year OMIP run on the
ss/omip-prototypebranch (two configurations: half-degree TripolarGrid and ORCA-NCAR). Both cases show winter MLD barely reaching 50–100 m, far shallower than observed values (500–2000 m in the Labrador Sea, 200–500 m in the Southern Ocean):Test plan
🤖 Generated with Claude Code