Add an energy conservation example and test#186
Open
simone-silvestri wants to merge 8 commits intoss/snow-model-integrationfrom
Open
Add an energy conservation example and test#186simone-silvestri wants to merge 8 commits intoss/snow-model-integrationfrom
simone-silvestri wants to merge 8 commits intoss/snow-model-integrationfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
navidcy
approved these changes
Apr 30, 2026
navidcy
reviewed
Apr 30, 2026
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Updated comments to use consistent multiplication syntax and improved clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an energy conservation example and a test for energy conservation.
It depends on the fixes scattered through here and ClimaSeaIce (#164 and https://github.com/CliMA/ClimaSeaIce.jl/pulls).
The freshwater flux is also calculated but not balanced, so when the issue of energy conservation is resolved and this is merged I will focus on tracking down mass conservation