feat: add theme toggle and improve error handling#39
Open
riccardogiorato wants to merge 5 commits intoNutlope:mainfrom
Open
feat: add theme toggle and improve error handling#39riccardogiorato wants to merge 5 commits intoNutlope:mainfrom
riccardogiorato wants to merge 5 commits intoNutlope:mainfrom
Conversation
- Fix Nutlope#37: Add error state handling in PreviewClient when resumeQuery or usernameQuery fails, showing a user-friendly error message with a refresh button instead of an infinite loading spinner or crash - Fix Nutlope#36: Prevent crash in Header.tsx when website URL is malformed by wrapping new URL() in a try/catch block - Fix Nutlope#36: Prevent crash in EditResume when resume.header.skills is undefined/null (legacy data) by using nullish coalescing (?? []) in all skills array operations https://claude.ai/code/session_017oUgH1Y6iZmosXcmutVYKF
- Add ThemeToggle component with Sun/Moon/Monitor icons dropdown (Light, Dark, System options) using next-themes + existing CSS vars - Wire ThemeProvider into layout.tsx with suppressHydrationWarning - Place ThemeToggle in TopMenu header, visible for all users - Fix Nutlope#31/Nutlope#33: add whitespace-pre-wrap to Summary component so multi-line descriptions render with correct line breaks https://claude.ai/code/session_017oUgH1Y6iZmosXcmutVYKF
Contributor
|
@claude is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Soften dark background from near-black (3.9%) to dark gray (9%) - Replace all hardcoded colors with semantic tokens: text-design-black → text-foreground text-design-gray/text-gray-* → text-muted-foreground bg-gray-100 → bg-muted bg-design-black → bg-primary border-gray-* → border-border/border hover:bg-gray-100 → hover:bg-muted - Add dark:invert to SVG icons (logo, github, x, sparkle, arrows) so they stay visible on dark backgrounds - Apply changes to: page.tsx, Footer, TopMenu, upload client https://claude.ai/code/session_017oUgH1Y6iZmosXcmutVYKF
- CustomSpinner: add dark:invert so black SVG paths show on dark bg - PreviewActionbar: replace bg-[#fcfcfc]/bg-white/border-neutral-300/ text-design-black/bg-design-black/bg-design-white with semantic bg-card/bg-background/border-border/text-foreground/bg-primary tokens; add dark:invert to link icon; fix spinner border color - preview/client.tsx: border-neutral-300 → border-border on resume card https://claude.ai/code/session_017oUgH1Y6iZmosXcmutVYKF
Updated the Tech stack section header to emphasize importance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds dark mode support with a theme toggle component and improves error handling and UI robustness across the application.
Key Changes
Theme Support: Added
ThemeTogglecomponent with light/dark/system theme options usingnext-themesThemeProviderinto root layout with class-based theme attributesuppressHydrationWarningon html element to prevent hydration mismatchesError Handling: Improved error handling in preview client
Null Safety: Fixed potential null reference issues in resume editing
??) for skills array throughoutEditResumecomponentURL Parsing: Added error handling for website URL parsing in resume header
new URL()call in try-catch to handle invalid URLsUI Improvements:
whitespace-pre-wrapclassImplementation Details
lucide-reacticons for theme toggle UInext-themeslibrary for theme management'use client'directivehttps://claude.ai/code/session_017oUgH1Y6iZmosXcmutVYKF