fix: replace remote IMDB logo URL with local SVG asset#774
Open
AbhishekVankar wants to merge 1 commit intoNuvioMedia:mainfrom
Open
fix: replace remote IMDB logo URL with local SVG asset#774AbhishekVankar wants to merge 1 commit intoNuvioMedia:mainfrom
AbhishekVankar wants to merge 1 commit intoNuvioMedia:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The IMDb logo in RatingsSection was loaded from a Wikipedia CDN URL:
https://upload.wikimedia.org/wikipedia/commons/thumb/6/69/IMDB_Logo_2016.svg/...
This caused the logo to silently fail to load on physical devices (Wikipedia blocks hotlinking from apps), showing only the rating number with no icon.
Additionally, MetadataDetails.tsx was passing the SVG import directly to FastImage as a source, which doesn't support SVGs and throws an error.
Changes
Added assets/rating-icons/imdb.svg — a clean SVG with no external dependencies
RatingsSection.tsx — switched IMDb from a remote URI (FastImage) to the local SVG component, with an iconScale multiplier so the square badge renders at a readable size alongside other rating icons
MetadataDetails.tsx — replaced with since SVGs must be rendered as components, not passed as raster image sources
Result
IMDb logo now renders reliably offline and on all devices without any network request.
@
closes #761