Skip to content

fix(compare-form): Type error: Cannot find name 'data' #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
O2sa merged 1 commit into from
Apr 26, 2026
Merged

fix(compare-form): Type error: Cannot find name 'data' #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ function HomePageInner() {
loading={loading}
reset={reset}
swapUsers={swapUsers}
data={Boolean(data)}
hasData={Boolean(data)}
/>

{loading && skeleton}
Expand Down
5 changes: 3 additions & 2 deletions components/compare-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type CompareFormProps = {
username2: string;
setUsername1: (value: string) => void;
setUsername2: (value: string) => void;
data?: boolean;
hasData?: boolean;
onSubmit: (u1: string, u2: string) => void;
loading?: boolean;
reset?: () => void;
Expand All @@ -29,6 +29,7 @@ export function CompareForm({
username2,
setUsername1,
setUsername2,
hasData,
onSubmit,
loading,
swapUsers,
Expand All @@ -44,7 +45,7 @@ export function CompareForm({
}, []);

const canSubmit = Boolean(username1.trim() && username2.trim() && !loading);
const isEmpty = (!username1.trim() && !username2.trim()) && !data;
const isEmpty = (!username1.trim() && !username2.trim()) && !hasData;

const handleSwap = () => {
if (swapUsers) swapUsers();
Expand Down
Loading