Add 10.0 project task analytic tag #88

ljimenezsidoo · 2017-04-20T14:57:40Z

Project Task Analytic Tag

This module extends the functionality of project to support to
add Tags in the timesheet and allow you to use the tags of the projects in your timesheet

oca-clabot · 2017-04-20T14:57:46Z

Hey @acm1pt-colorado, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Luis Adan JH (no github login found)

Appreciation of efforts,
OCA CLAbot

elicoidal · 2017-04-21T01:09:17Z

project_task_analytic_tag/README.rst

+Project Task Analytic Tag
+=========================
+
+This module extends the functionality of project and mrp_repair to support to


mrp_repair?
It is not in dependency list and anyway would simply need another module if you'd wish to do so.

Isnot this module overlapping with https://github.com/OCA/project/tree/10.0/project_categ and https://github.com/OCA/project/tree/10.0/project_categ_issue?

I am not so much in favor of adding a new category system without clear value

Hi @elicoidal , you are right about README, it's a mistake about copy & paste from other module.

But this module is not overlapping with project category. The target to add analytic tags to project task is to create analytic lines (timesheet lines) with right tag.

This way you can set tags like "Design", "Develop", "Testing"... on your timesheet lines, and you will be able to get analytic about type of work you was doing. Also interesting in combination with analytic dimensions.

Add a note in the README

angelmoya · 2017-04-21T10:20:22Z

I copy this comment because it's hidden by outdated change, but I think is usefull to see for other reviewers

This module is not overlapping with project category. The target to add analytic tags to project task is to create analytic lines (timesheet lines) with right tag.
This way you can set tags like "Design", "Develop", "Testing"... on your timesheet lines, and you will be able to get analytic about type of work you was doing. Also interesting in combination with analytic dimensions.

elicoidal · 2017-04-21T12:51:59Z

@angelmoya then I would suggest to make it permanent in the README ;)

elicoidal · 2017-04-21T12:52:19Z

project_task_analytic_tag/README.rst

+   :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+   :alt: License: AGPL-3
+
+Project Task Analytic Tag


Line before for the document title

elicoidal · 2017-04-21T12:56:28Z

project_task_analytic_tag/README.rst

+Project Task Analytic Tag
+=========================
+
+This module extends the functionality of project to support to


"This module extends the functionality of project to support Tags in timesheet and the possibility to add them from the projects."

elicoidal · 2017-04-21T12:56:40Z

project_task_analytic_tag/README.rst

+
+To install this module, you need to:
+
+- First Add in the addons path the module and install in your odoo.


elicoidal · 2017-04-21T13:04:44Z

project_task_analytic_tag/README.rst

+
+To use this module, you need to:
+
+- Go to project and enter in a task section, here you only need to go to the


make better use of enumerated list "#. " for procedures. For example:

#. Go to project and enter in a task section, #. Go to the page timesheet #. You can add a new element. #. When you add the tag in the extra Information, the tag is automatically set for newly added element.

When i read the code, I dont get all above mentioned feature though.
Anything I missed?

Really no more code is needed, now on tasks, timesheets page are analytic entries (previously are timesheet_sheet_lines that are related).
Then this module just show tag_ids from analytic_account_line on project_task. And set analytic_tag_ids on project task to define default analytic_tag_ids for all timesheets (account_analytic_line) for this task.

elicoidal · 2017-04-21T13:04:53Z

project_task_analytic_tag/README.rst

+  extra-Information, when you add a new element the tag is set auto.
+
+
+Known issues / Roadmap


remove the section

ljimenezsidoo · 2017-04-24T09:56:42Z

@elicoidal thanks for the comments all the changes updated

dreispt · 2017-04-27T14:15:18Z

I wonder if OCA/project is not better suited for this.

From the functional PoV, it's not clear to me the use case for this.
Why do we want several analytic accounts on the same task? How do you analyse Tasks then?

angelmoya · 2017-04-27T14:51:47Z

Hi @dreispt , we also were thinking about puting it on OCA/project , but finally we thought that final scope is to get correct analytic accounting.

You are wrong about this "several analytic accounts on the same task", it's not for analytic accounts, is for analytic tags. This way you can set type of work you are doing in one task.

Without this module you can not set analytic tags for this account.analytic.lines

dreispt · 2017-04-28T07:40:27Z

@angelmoya I see, but what is the point. Can you give a real life example of haw this is used?
Don't take me wrong, I just want to better understand the use case.

angelmoya · 2017-04-28T08:01:51Z

Sorry @dreispt , I said you are wrong because you said account instead tag, and I thought that you can undertand the scope using analytic tags.

Ok, for example.

you have a project, that is an analytic account, remember that you lose hierarchical structure on analytic account.
then you create a task on this project, your task could be "Design 3D for new component" and you can set analytic tag on task "Design 3D". Other task could be "Manufacture prototype" with other analytic tag, on same project.
as you set analytic tag on project task (then in timesheet lines), then your analytic account line has correct analytic tag.
Then you can get from analytic account things like "Total amounts by Design 3D by project" or "Total by project by analytic tag (Design 3D, Prototype)"

My real use case is more easy, I improve the use of mrp_repair, to be able to create projects and task. Then all task created from RMA has analytic tag "RMA" and then you can get analytic account for RMA.

All this could be better if you install also #87 this way you can group analytic tags on dimensions like:

type of project (Productive, RMA, ...)
type of task (Design, Manufacture, Manage, ...)
departments ....

dreispt · 2017-04-28T08:19:14Z

For the example, IMO it would be better to have an Analytic Account on Tasks. This has been done on OCA/project (although looking the module name - service_desk - is unfortunate).
My use case is a "Corrective Maintenance" project, where I open tasks, and then on each Task I select the Contract (Analytic Account) it corresponds to.

pedrobaeza · 2017-04-28T08:30:46Z

Since v9, there's a field analytic_account_id in tasks and issues...

dreispt · 2017-04-28T08:35:05Z

@pedrobaeza Thanks! I guess it shows I'm still on v8 😛
So we already know the task Analytic Tags - just follow the Task analytic_account_id, right?

pedrobaeza · 2017-04-28T08:40:07Z

Yeah, at task or issue level you can predefine an analytic account to be filled for timesheet entries, so theoretically you can switch this analytic account for changing where to put the entry. We have been working on restoring analytic hierarchy. Have you seen it?

dreispt · 2017-04-28T08:44:49Z

I haven't read the RFC yet, but I'm aware it is being discussed.
Tags don't replace Parents: they don't support things like WBS, relevant for non trivial Projects.

pedrobaeza · 2017-04-28T08:54:07Z

It's no more an RFC, but an implementation: https://github.com/OCA/account-analytic/tree/9.0/account_analytic_parent and an improvement here: #91

angelmoya · 2017-04-28T10:28:13Z

@dreispt with analytic dimension you can support things like WBS, and I think that it could be better than use analytic parent.

You can think on this structure with analytic parent:

Customer 1
- Project 1
  - Materials 1
  - Hours 1

With previous structure, if you use parent account you need to create one account for each Materials of each Project. And you need to set task on Materials or on Hours.

Also on BI you can not view amounts group rightly.

If you use dimensions you can do things like:

Customer (directly customer because res.partner is on analytic.line)
- Project (analytic account without parent)
- Materials (dimension concept = materials, created dimanicaly on analytic.line)
- Hours (dimension concept = hours, created dimanicaly on analytic.line)

And you can use on BI, and group on diferents dimensions on diferent order.

Is hard to me to explain in english, but I really think that tags with dimensions are better way to do analytic. And for BI is better than use parent account.

On v8 I did things like add parent_id on BI, and parent_parent_id, and product_category, to get similar functionality, and know this could be done automatically.

dreispt · 2017-04-28T11:24:49Z

That was a great explanation, and I think I understand your point.
From my PoV the scenario you describe is implemented with two Dimensions: Dim1="Project" and Dim2="Resource"".
Both of them are a hierarchy of analytic accounts:

Project Dimension
- Customer 1
  - Project 1
Resource Dimension
- Materials
- Time

Now each analytic line should have be assigned to a "analytic combination", with values for each of the Dimensions. have a look at this.

Maybe what I describe if far from being possible in practice and your approach is a good short term solution. We're just discussing here.

angelmoya · 2017-05-03T10:17:24Z

@dreispt @pedrobaeza one more review to aprove?

dreispt · 2017-05-03T16:13:39Z

project_task_analytic_tag/models/project_task_tag.py

+
+    analytic_tag_ids = fields.Many2many(
+        comodel_name='account.analytic.tag',
+        relation='default_tag_account_tag',


Convention is for this table to end with _rel

dreispt · 2017-05-03T16:17:51Z

project_task_analytic_tag/__manifest__.py

+    "license": "AGPL-3",
+    "depends": [
+        'project',
+        "hr_timesheet"


This is related to analytic_tag_dimension right?
Does it make sense to add it as a dependency?
If not, at least that module should be mentioned in the README, as a way to use the information added here.

Hi @dreispt , it's not related, and is not a dependency.

You can use it alone, to set analytic tag on analytic lines created on timesheet.

We only talk about the other module to explain why we decided to improve analytic tags instead of migrate analytic account parent.

@dreispt The dependency is not necessary. As @angelmoya said you can use it alone.

@dreispt Do you agree that there is no need for dependency? I'm going to add in the readme file for more info as you said.

rafaelbn · 2018-09-14T13:32:10Z

Rebuilding for testing @angelmoya

rafaelbn · 2018-09-14T15:51:12Z

@angelmoya @acm1pt-colorado could you please rebase? I cannot test it. Travis fails and runbot doesn't build 😢

angelmoya · 2018-09-14T17:30:54Z

Done, I will check new travis error El vie., 14 sept. 2018 17:51, Rafael Blasco <notifications@github.com> escribió:

…

@angelmoya <https://github.com/angelmoya> @acm1pt-colorado <https://github.com/acm1pt-colorado> could you please rebase? I cannot test it. Travis fails and runbot doesn't build 😢 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGcAhZvJjUq4SNJsxNBRYXpt5VGfqqUmks5ua9BygaJpZM4NDJtJ> .

rafaelbn · 2018-09-17T22:03:08Z

Hi @angelmoya , I've tested functionally and it's 👍

But I don¡t understand why in this PR are you changing files of other modules: https://github.com/OCA/account-analytic/pull/88/files#diff-de1af174f37e99cfcd5af533f2eeb68f

❓ 😄

rafaelbn

Functionally 👍

But in this PR "Files changed 934" 😲

angelmoya · 2018-09-18T08:36:02Z

OK @rafaelbn , maybe was a problem with rebase, I did it again and do force push to do in one commit and only update my module files.

github-actions · 2021-10-24T12:32:56Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

elicoidal reviewed Apr 21, 2017

View reviewed changes

elicoidal suggested changes Apr 21, 2017

View reviewed changes

elicoidal approved these changes Apr 24, 2017

View reviewed changes

angelmoya approved these changes Apr 24, 2017

View reviewed changes

dreispt reviewed May 3, 2017

View reviewed changes

rafaelbn added this to the 10.0 milestone Sep 14, 2018

rafaelbn closed this Sep 14, 2018

rafaelbn reopened this Sep 14, 2018

rafaelbn added the needs review label Sep 14, 2018

rafaelbn requested changes Sep 17, 2018

View reviewed changes

angelmoya force-pushed the ADD-10.0-project_task_analytic_tag branch from 8c5d3c8 to 85a5ae5 Compare September 18, 2018 08:34

angelmoya force-pushed the ADD-10.0-project_task_analytic_tag branch from 85a5ae5 to 6e4d8c7 Compare September 18, 2018 09:50

ADD project_task_analytic_tag module

42ac8cc

ljimenezsidoo force-pushed the ADD-10.0-project_task_analytic_tag branch from 6e4d8c7 to 42ac8cc Compare October 7, 2020 16:08

ljimenezsidoo requested review from dreispt, elicoidal and rafaelbn October 9, 2020 07:44

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021

github-actions bot closed this Nov 28, 2021


		To install this module, you need to:

		- First Add in the addons path the module and install in your odoo.


		To use this module, you need to:

		- Go to project and enter in a task section, here you only need to go to the

		extra-Information, when you add a new element the tag is set auto.


		Known issues / Roadmap

Uh oh!

Add 10.0 project task analytic tag #88

Add 10.0 project task analytic tag #88

Uh oh!

Conversation

ljimenezsidoo commented Apr 20, 2017

Project Task Analytic Tag

Uh oh!

oca-clabot commented Apr 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelmoya commented Apr 21, 2017

Uh oh!

elicoidal commented Apr 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljimenezsidoo commented Apr 24, 2017

Uh oh!

dreispt commented Apr 27, 2017

Uh oh!

angelmoya commented Apr 27, 2017

Uh oh!

dreispt commented Apr 28, 2017

Uh oh!

angelmoya commented Apr 28, 2017

Uh oh!

dreispt commented Apr 28, 2017

Uh oh!

pedrobaeza commented Apr 28, 2017

Uh oh!

dreispt commented Apr 28, 2017

Uh oh!

pedrobaeza commented Apr 28, 2017

Uh oh!

dreispt commented Apr 28, 2017

Uh oh!

pedrobaeza commented Apr 28, 2017

Uh oh!

angelmoya commented Apr 28, 2017

Uh oh!

dreispt commented Apr 28, 2017

Uh oh!

angelmoya commented May 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Sep 14, 2018

Uh oh!

rafaelbn commented Sep 14, 2018

Uh oh!