Skip to content

[19.0][ADD] lims#31

Open
etobella wants to merge 8 commits intoOCA:19.0from
dixmit:19.0-add-lims
Open

[19.0][ADD] lims#31
etobella wants to merge 8 commits intoOCA:19.0from
dixmit:19.0-add-lims

Conversation

@etobella
Copy link
Copy Markdown
Member

@etobella etobella commented Feb 9, 2026

TODO:

  • Add tests
  • Add JS Tests
  • Add context
  • Add templates for autogenerating elements -> Should be handled by sale orders....
  • Removed relation to products and replace it for analytes. The decision is taken because Products relate more to analyte + sample types, making it easier to handle this way (in lims_sale, the relation will be retaken by using specs)
  • Improved views and added a widget for handling the multiple values in a better way
  • Review colors by status (limits and so on)
  • Report

Co-authored-by: Kevin Luna <kevin.luna@creublanca.es>
@etobella etobella force-pushed the 19.0-add-lims branch 2 times, most recently from 41c0c59 to 2510a47 Compare February 10, 2026 05:44
@etobella etobella force-pushed the 19.0-add-lims branch 2 times, most recently from 449998d to cd2803b Compare February 11, 2026 19:33
@etobella
Copy link
Copy Markdown
Member Author

@max3903 I think it would be interesting if you could review my proposal. I think you will like the approach.

@max3903
Copy link
Copy Markdown
Member

max3903 commented Feb 11, 2026

@etobella Not sure I will have time. Also the team moved forward with the implementation of #20

@etobella
Copy link
Copy Markdown
Member Author

@max3903 Thanks for the clarification.

On #20, there were requested changes during review that were never addressed. Before moving forward or merging, those comments need to be resolved. They were raised early in the PR process and are still outstanding.

As mentioned previously, I would prefer to keep the core implementation minimal and extensible. If additional complexity is needed, I prefer introducing it through submodules rather than expanding the core. To put some an example from your code, batches are cool, but it doesn't make sense on Point of Care Laboratories. For this reason it shouldn't go to the base module.

Please address the review comments and consider simplifying the approach so it aligns better with the intended design.

@etobella etobella force-pushed the 19.0-add-lims branch 5 times, most recently from 12b7a5b to 335ffc2 Compare February 19, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants