[18.0][IMP] account_credit_control - multi-channel policies #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
requested review from
grindtildeath,
len-foss,
qgroulard and
sergio-teruel
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
from
0ed05a7 to
c5b6bbb
Compare
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
3 times, most recently
from
b0f32b8 to
9192aac
Compare
qgroulard
reviewed
Aug 7, 2025
Contributor
qgroulard
left a comment
qgroulard
left a comment
There was a problem hiding this comment.
Great addition 👍
Multi-channel seems to be a really common need to me (already supported by Odoo Follow-Up btw).
I like this simple solution.
| ) | ||
| channel = fields.Selection( | ||
| selection=CHANNEL_LIST, | ||
| required=True, |
Contributor
There was a problem hiding this comment.
We lose this required, I guess we should add a check to make sure that at least one channel field is True.
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
2 times, most recently
from
69bb64b to
f3621fc
Compare
Member
Author
|
Fixed tests by taking in account |
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
from
f3621fc to
db09068
Compare
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
from
db09068 to
ee4d8be
Compare
baimont
approved these changes
Sep 15, 2025
Contributor
baimont
left a comment
baimont
left a comment
There was a problem hiding this comment.
nice pr, a small fix to make tests pass
Adds the possibility to send reminders via multiple channels for the same level. For instance you can send you reminders both by email and letter.
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
from
9958193 to
d4624d7
Compare
qgroulard
approved these changes
Sep 17, 2025
Member
Author
|
Tests to be fixed |
yvaucher
force-pushed
the
18-account_credit_control-multi-channel
branch
from
067a600 to
da4eba2
Compare
…hannel [IMP] account_credit_control: multi-channel policies migration script
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(superseeded by #522 )
Adds the possibility to send reminders via multiple channels for the same level.
Sometimes you want to send reminders on multiple channels at the same time for instance send an email as well as sending a letter on high policy level.
This adds a checkbox for each channel.
Adding a new channel must be done by adding the following fields:
channel_<name>on bothcredit.control.lineandcredit.control.policy<name>_sentoncredit.control.lineLine is updated to
sentonly after all selected channels have been processed. It is still possible to force the manually the state to sent to settle the line.Policy level:
Credit control line:
TODO: