[18.0][MIG] web_view_leaflet_map: Migration to 18.0 #419

mourad-ehm · 2025-10-21T10:21:08Z

Migrate web_view_leaflet_map module from this pr #415

tate11 · 2025-10-22T19:03:25Z

web.assets_web_dark.min.js:41 Uncaught Error: Error while loading "@web_view_leaflet_map/components/map-component/map_view.esm":
Error: Invalid object: 'type' is not valid
at ModuleLoader.startModule (web.assets_web_dark.min.js:41:227)
at ModuleLoader.startModules (web.assets_web_dark.min.js:40:57)
at ModuleLoader.addJob (web.assets_web_dark.min.js:5:39)
at ModuleLoader.define (web.assets_web_dark.min.js:10:121)
at web.assets_web_dark.min.js:22891:6
web.assets_web_dark.min.js:23 The following modules failed to load because of an error: Array(1)
reportErrors @ web.assets_web_dark.min.js:23
share-modal.js:1 Uncaught TypeError: Cannot read properties of null (reading 'addEventListener')
at share-modal.js:1:135

…om 1.8.0, released on April 18, 2022.)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/

Currently translated at 100.0% (7 of 7 strings) Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/it/

…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/

This reverts commit a9570109

mourad-ehm · 2025-11-12T09:59:20Z

Hi @tate11, thanks for your review. The bug was fixed. could you test ?

web_view_leaflet_map/readme/DEVELOP.md

legalsylvain · 2025-11-17T10:05:11Z

Hi @mourad-ehm. Thanks for porting this module. I know that generaly, there is a module per PR, but in that case, could you also migrate trivial web_view_leaflet_map_partner module, so we can test on runboat, more easely ?

thanks !

mourad-ehm · 2025-11-17T10:31:51Z

Hi @legalsylvain, I have created this PR #420 for web_view_leaflet_map_partner.

OCA-git-bot · 2025-11-17T10:57:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain · 2025-11-17T11:05:13Z

Hi. tested on #425 / runboat.
works like a charm.
thanks for porting this module.

/ocabot merge nobump

OCA-git-bot · 2025-11-17T11:05:26Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-419-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot · 2025-11-17T11:08:50Z

Congratulations, your PR was merged at 19507b5. Thanks a lot for contributing to OCA. ❤️

legalsylvain · 2025-11-18T21:13:35Z

Hi. I installed the module on odoo 18 instance, and it looks like there is a regression.
The search bar is not visible in the map view. (it was present in v16 and V12)
it is so not possible to filter...

Did you faced similar issue ?

NL66278 · 2025-11-20T09:33:04Z

@legalsylvain Yes, I do not see a searchbar on 18.0. So same here.

legalsylvain · 2025-11-20T09:41:44Z

@mourad-ehm. Could you take a look on that regression ?
Thanks !

NL66278 · 2025-11-20T11:53:02Z

@legalsylvain @mourad-ehm I can get the map to show a searchbar with the attached patch. However it does not yet react to selected filters. So will need some more work, but I have not to much experience in owl how to do this, so maybe use this as a pointer to what might be needed?
searchbar.patch

thibaultrey force-pushed the 18.0-mig-web_view_leaflet_map branch from 75628c2 to ae08db6 Compare November 7, 2025 13:40

mourad-ehm changed the title ~~WIP [18.0][MIG] web_view_leaflet_map: Migration to 18.0~~ [18.0][MIG] web_view_leaflet_map: Migration to 18.0 Nov 12, 2025

legalsylvain and others added 26 commits November 12, 2025 10:50

[ADD] web_view_leaflet_map

c01b7e2

[UPD] Update web_view_leaflet_map.pot

ebb0145

[UPD] README.rst

eecf824

[ADD] icon.png

2367dc1

[IMP] web_view_leaflet_map: black, isort, prettier

cd38aff

[IMP] web_view_leaflet_map*: black, isort, prettier

ce3c1eb

[MIG] web_view_leaflet_map, web_view_leaflet_map_partner in V16

2be3907

[REF] Bump leaflet js library to 1.9.4, released on May 18, 2023. (fr…

b934b81

…om 1.8.0, released on April 18, 2022.)

[UPD] Update web_view_leaflet_map.pot

203515f

Update translation files

5c69639

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/

Added translation using Weblate (Italian)

79b114c

Translated using Weblate (Italian)

9c642fa

Currently translated at 100.0% (7 of 7 strings) Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/it/

[REF] split web_view_leaflet_map into web_view_leaflet_map and web_le…

c921385

…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)

[BOT] post-merge updates

2423203

[UPD] Update web_view_leaflet_map.pot

cb58702

Update translation files

9fecc06

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/

[IMP] web_view_leaflet_map: pre-commit auto fixes

b605ddc

[17.0][MIG] web_view_leaflet_map: Refactor to OWL component

eca9c0e

[17.0][MIG] web_view_leaflet_map: Refactor to OWL component

2844b03

Revert "Importer gitlab work"

82524a8

This reverts commit a9570109

[17.0][MIG] web_view_leaflet_map: Refactor to OWL component

fa847d7

[17.0][MIG] web_view_leaflet_map: Refactor to OWL component

e720f9b

[17.0][MIG] web_view_leaflet_map: pre-commit fix

f087173

[IMP] web_view_leaflet_map: pre-commit auto fixes

dc4f2d1

[MIG] web_view_leaflet_map: Migration to 18.0

9f97191

[MIG] web_view_leaflet_map: fix view mode declaration for 18.0 migration

a4c2500

mourad-ehm force-pushed the 18.0-mig-web_view_leaflet_map branch from ae08db6 to a4c2500 Compare November 12, 2025 09:53

thibaultrey approved these changes Nov 12, 2025

View reviewed changes

NL66278 reviewed Nov 13, 2025

View reviewed changes

web_view_leaflet_map/readme/DEVELOP.md Outdated Show resolved Hide resolved

[FIX] remove lealflet.js Library Update instructions from DEVELOP.md

f80691b

bealdav approved these changes Nov 17, 2025

View reviewed changes

OCA-git-bot added the approved label Nov 17, 2025

OCA-git-bot added the ready to merge label Nov 17, 2025

mourad-ehm requested a review from NL66278 November 17, 2025 11:00

OCA-git-bot added the bot is merging ⏳ label Nov 17, 2025

OCA-git-bot merged commit 370808a into OCA:18.0 Nov 17, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 17, 2025

bealdav deleted the 18.0-mig-web_view_leaflet_map branch November 17, 2025 11:44

legalsylvain mentioned this pull request Jan 5, 2026

[18.0] web_view_leaflet_map : add 'Create' missing button #434

Open

Uh oh!

[18.0][MIG] web_view_leaflet_map: Migration to 18.0 #419

[18.0][MIG] web_view_leaflet_map: Migration to 18.0 #419

Uh oh!

Conversation

mourad-ehm commented Oct 21, 2025

Uh oh!

tate11 commented Oct 22, 2025

Uh oh!

mourad-ehm commented Nov 12, 2025

Uh oh!

Uh oh!

legalsylvain commented Nov 17, 2025

Uh oh!

mourad-ehm commented Nov 17, 2025

Uh oh!

OCA-git-bot commented Nov 17, 2025

Uh oh!

legalsylvain commented Nov 17, 2025

Uh oh!

OCA-git-bot commented Nov 17, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Nov 17, 2025

Uh oh!

legalsylvain commented Nov 18, 2025

Uh oh!

NL66278 commented Nov 20, 2025

Uh oh!

legalsylvain commented Nov 20, 2025

Uh oh!

NL66278 commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants