[15.0][ADD] hr_attendance_rest_time_included: New module

[eduezerouali-tecnativa]

cc @Tecanativa TT59859
ping @pedrobaeza @juancarlosonate-tecnativa @david-banon-tecnativa

This module allows tracking employee rest times (breaks) that are included in the employee’s working time.

[pedrobaeza]

@eduezerouali-tecnativa you have to add at attendance reason level, when being "Sign out" one, a check for saying if it's a rest time included in the attendance.

[pedrobaeza]

I see you have added it as a configuration option inside settings, but it should be at attendance reason level, as it can be more than one reason.

[pedrobaeza]

Apart from the comments inline, include in the ROADMAP that this module is not totally compatible with hr_attendance_geolocation, as I have seen that the sign out coordinates are stored in the main attendance record while signing out the rest time. On upper versions, where the geolocation is included, we will need to check how to make it compatible.

[pedrobaeza]

This is inside hr.attendance, so the prefix hr_attendance is useless, redundant and takes a lot of space, and on the other side, use _ids suffix convention for o2m:

Suggested change

	hr_attendance_rest_time = fields.One2many(
	rest_time_ids = fields.One2many(

[pedrobaeza]

For indicating the intention of inheritance with new model, better to put before _inherit and then _name:

Suggested change

	_name = "hr.attendance.rest_time"
	_inherit = "hr.attendance"
	_inherit = "hr.attendance"
	_name = "hr.attendance.rest_time"

[pedrobaeza]

Don't add empty lines inside a method (it applies to all the code).

[eduezerouali-tecnativa]

All changes apply !

[pedrobaeza]

Apart from the inline comments, we are almost there. Some other changes:

• It seems the original chatter is being rewritten when checking out/in the rest time:

  

• There's no navigation nor visualization of the rest time attendances. Put a button next to the rest time column to go to them, and also a smart-button on the main attendance record, both only visible when there are rest time attendances.

[eduezerouali-tecnativa]

Small comments already fix (not push yet). About the chatter, this is only available if you install hr_attendance_modification_tracking in upper odoo version is directly into core. Should we add a glue module to fix that?

[pedrobaeza]

About the chatter, this is only available if you install hr_attendance_modification_tracking in upper odoo version is directly into core. Should we add a glue module to fix that?

No need of the glue module then, but also a mention in the ROADMAP.

[eduezerouali-tecnativa]

add changes, plus the mention to ROADMAP

[pedrobaeza]

Last fix:

[eduezerouali-tecnativa]

ping @pedrobaeza

[pedrobaeza]

Can you put another icon like the clock for the button to go the the breaks?

[eduezerouali-tecnativa]

done

[eduezerouali-tecnativa]

added Spanish translations, not 100% if it goes in an other commit or i should just squash them

[pedrobaeza]

It should go in the same commit as the other, and anyway, if in a separate commit, it shouldn't be [ADD], as that's just for adding modules, but squash it as said.

[eduezerouali-tecnativa]

It should go in the same commit as the other, and anyway, if in a separate commit, it shouldn't be [ADD], as that's just for adding modules, but squash it as said.

okay, i got that from an other module commit as reference to add translation without using weblate. Anyways i just add it to the commit. Thank you!

[pedrobaeza]

Why adding this if it's invisible?