[18.0][MIG] document_knowledge: Migration to 18.0 #503

Kimkhoi3010 · 2024-11-05T10:23:55Z

No description provided.

* Copyright and various stuff * Contributors * External ID not found in the system: base.group_document_user

Currently translated at 93.9% (31 of 33 strings) Translation: knowledge-11.0/knowledge-11.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-knowledge/pt_BR/

It solves this: OCA#179

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Otherwise the module grants too wide permissions for all users.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/

Currently translated at 57.7% (15 of 26 strings) Translation: knowledge-12.0/knowledge-12.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/

Currently translated at 57.7% (15 of 26 strings) Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/he_IL/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/

Currently translated at 100.0% (26 of 26 strings) Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/ru/

OCA-git-bot · 2024-11-12T09:22:05Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

houssine78

LGTM

houssine78 · 2024-11-12T12:27:12Z

@pedrobaeza a new PR that can be merge here :)

pedrobaeza

Controversial opinion about removing the settings part, but this is a frequent source of questions/problems cc @max3903

pedrobaeza · 2024-11-12T17:21:55Z

document_knowledge/models/res_config.py


    module_attachment_indexation = fields.Boolean(
        "Attachments List and Document Indexation",
-        help="Document indexation, full text search of attachements.\n"


I prefer that you remove all the options, as this is not valid if the rest of the modules aren't there.

@pedrobaeza Thanks for your time!!
Can you explain more so I can better understand what you want.

I mean that having these module_* fields is for installing modules that are still not migrated, but even if migrated, you may not have those modules present on your Odoo instance, so clicking on the checks provoke confusion and misleading in users, so I propose to remove these fields from the configuration.

pedrobaeza · 2024-11-12T17:22:05Z

document_knowledge/readme/CREDITS.md


 - Camptocamp
+
+The migration of this module from 17.0 to 18.0 was financially supported


Remove the previous text.

pedrobaeza · 2024-11-13T08:52:08Z

Thanks for the changes. I think you have stripped now too much, as I was just talking about module_* fields, not the rest.

pedrobaeza · 2024-11-13T08:52:16Z

/ocabot migration document_knowledge

Kimkhoi3010 · 2024-11-13T08:59:08Z

Thanks for the changes. I think you have stripped now too much, as I was just talking about module_* fields, not the rest.

It was my fault. I fixed it. Thanks for your time!!

houssine78 · 2024-11-13T09:37:57Z

thanks @pedrobaeza for this insightful review.

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-11-13T23:20:08Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-503-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-11-13T23:23:36Z

Congratulations, your PR was merged at 433dcc3. Thanks a lot for contributing to OCA. ❤️

naousse and others added 30 commits October 29, 2024 17:33

knowledge module added from Odoo 8.0 and ported to 9.0

73c9ff5

Add CMIS modules to Settings

820e6f5

Port to v10

a94f7e0

[FIX] knowledge: Several things

4e36cf5

* Copyright and various stuff * Contributors * External ID not found in the system: base.group_document_user

knowledge: migrations scripts

00910d8

knowledge: Migration to 11.0

e543e74

[MIG] knowledge: Complete migration

8282ed4

[IMP] knowledge: add missing menus

94db74e

Translated using Weblate (Portuguese (Brazil))

62a7635

Currently translated at 93.9% (31 of 33 strings) Translation: knowledge-11.0/knowledge-11.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-knowledge/pt_BR/

[FIX] remove the set and get values in res.config

70f98d3

Fixing items' link error.

e28349c

It solves this: OCA#179

Enterprise-like icon

37e8982

[knowledge] Consider the module as a fully-fledge application

f3d2e81

Add icon svg master file

94e2ef7

Update translation files

6fac641

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[knowledge][11.0.3.0.0] - add security for access to ir.attachment.

8e43688

Otherwise the module grants too wide permissions for all users.

[FIX] pylint/javascript-lint

ed94663

[MIG] knowledge: Migration to 12.0

410538b

Update translation files

852e7f4

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/

Translated using Weblate (French)

49b26cb

Currently translated at 57.7% (15 of 26 strings) Translation: knowledge-12.0/knowledge-12.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/fr/

[IMP] knowledge: black, isort

317a62f

[MIG] knowledge: Migration to 13.0

8044c75

Update translation files

2a381f0

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/

pre-commit update

1decaea

[13.0][FIX] round icon

12e34f9

knowledge 13.0.1.0.1

ba66142

Added translation using Weblate (Hebrew)

853cb50

Translated using Weblate (Hebrew)

d02f74c

Currently translated at 57.7% (15 of 26 strings) Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/he_IL/

Update translation files

efb5c63

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/

Translated using Weblate (Russian)

a46fc93

Currently translated at 100.0% (26 of 26 strings) Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/ru/

Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch 2 times, most recently from 4d50f59 to 6b28bbe Compare November 8, 2024 05:53

TDu approved these changes Nov 11, 2024

View reviewed changes

jdoutreloux approved these changes Nov 12, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 12, 2024

houssine78 approved these changes Nov 12, 2024

View reviewed changes

pedrobaeza requested changes Nov 12, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 12, 2024

Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch from 6b28bbe to 986fef4 Compare November 13, 2024 08:45

Kimkhoi3010 requested a review from pedrobaeza November 13, 2024 08:46

OCA-git-bot added this to the 18.0 milestone Nov 13, 2024

Kimkhoi3010 added 2 commits November 13, 2024 15:55

[ADD] - checklog-odoo.cfg

9cc5acb

[MIG] document_knowledge: Migration to 18.0

f82dce4

Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch from 986fef4 to f82dce4 Compare November 13, 2024 08:56

pedrobaeza approved these changes Nov 13, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 13, 2024

OCA-git-bot added the bot is merging ⏳ label Nov 13, 2024

OCA-git-bot merged commit a7eba92 into OCA:18.0 Nov 13, 2024
4 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 13, 2024


		- Camptocamp

		The migration of this module from 17.0 to 18.0 was financially supported

Uh oh!

[18.0][MIG] document_knowledge: Migration to 18.0 #503

[18.0][MIG] document_knowledge: Migration to 18.0 #503

Uh oh!

Conversation

Kimkhoi3010 commented Nov 5, 2024

Uh oh!

OCA-git-bot commented Nov 12, 2024

Uh oh!

houssine78 left a comment

Choose a reason for hiding this comment

Uh oh!

houssine78 commented Nov 12, 2024

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

Kimkhoi3010 Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Nov 13, 2024

Uh oh!

pedrobaeza commented Nov 13, 2024

Uh oh!

Kimkhoi3010 commented Nov 13, 2024

Uh oh!

houssine78 commented Nov 13, 2024

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 13, 2024

Uh oh!

Uh oh!

OCA-git-bot commented Nov 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants