[17.0][FIX] document_url: Fix Download attachment component #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maq-adhoc
force-pushed
the
17.0-fix-document-url-maq
branch
2 times, most recently
from
2e90b9b to
ede53e3
Compare
giarve
approved these changes
Nov 9, 2024
giarve
left a comment
giarve
left a comment
There was a problem hiding this comment.
I can confirm it needs a patch for 17.0 and this one is not looking bad
Contributor
|
This PR has the |
Member
|
Please use proper commit message: |
maq-adhoc
force-pushed
the
17.0-fix-document-url-maq
branch
from
ede53e3 to
879688f
Compare
maq-adhoc
changed the title
maq-adhoc
changed the title
Fix download atachment widget. Document_url when activated causes error when opening attachment link on the chatter window This commit (odoo/odoo@366676c) move download buttons into a sub-component. I modified the module behavior to use canDownload() method instead of adding a t-if in the view and prevent the chatter component from breaking when the message has attachments.
maq-adhoc
force-pushed
the
17.0-fix-document-url-maq
branch
from
879688f to
0b11b08
Compare
Contributor
Author
|
@pedrobaeza I think it's okay now. Thanks |
pedrobaeza
changed the title
pedrobaeza
approved these changes
Nov 14, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Thanks, that's it.
/ocabot merge patch
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 4c08cb8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit (odoo/odoo@366676c) move download buttons into a sub-component.
I modified the module behavior to use canDownload() method instead of adding a t-if in the view and prevent the chatter component from breaking when the message has attachments.