Skip to content

[16.0][MIG] attachment_preview: Migration to 16.0 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anusriNPS wants to merge 28 commits into from
Closed

[16.0][MIG] attachment_preview: Migration to 16.0 #514

anusriNPS wants to merge 28 commits into from

Conversation

@anusriNPS
Copy link

@anusriNPS anusriNPS commented Jan 2, 2025

Migrating attachment_preview to 16.0

@anusriNPS anusriNPS marked this pull request as draft January 2, 2025 10:08
@anusriNPS anusriNPS force-pushed the 16.0-mig-attachment_preview branch from 55cfa05 to 226b097 Compare January 2, 2025 11:01
hbrunn and others added 28 commits January 2, 2025 12:03
@hbrunn @anusriNPS
[ADD] preliminary port of attachment_preview
55a6b3b
@gurneyalex @anusriNPS
Add OCA as author of OCA addons
ecb10a9 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@sysadminmatmoz @anusriNPS
Slovene translations added
79bea84
@sbidoul @anusriNPS
[UPD] prefix versions with 8.0
947f31d
@pedrobaeza @anusriNPS
[MIG] Make modules uninstallable
1e24cd4
@tarteo @anusriNPS
[MIG] attachment_preview: Migration to 11.0
3d42b35 
[FIX] Lint

[FIX] lint and flake

[ADD] tests

[ADD] tests

[ADD] tests

[ADD] Tests

[ADD] Package python-magic

[ADD] Tests

[FIX] Lint
@OCA-git-bot @anusriNPS
[UPD] README.rst
a7391f0
@oca-travis @anusriNPS
[UPD] Update attachment_preview.pot
77a20f3
@astirpe @anusriNPS
[FIX] Robustness when attachment not present
22c9aa5
@tarteo @anusriNPS
[IMP] attachment_preview: Split screen
0408c85
@OCA-git-bot @anusriNPS
[UPD] README.rst
6460442
@MiquelRForgeFlow @anusriNPS
[FIX] pylint/javascript-lint
863fc91
@tarteo @anusriNPS
[MIG] attachment_preview: Migration to 12.0
85e4fa3 
[REM] Old files

[ADD] Magic to travis file

[FIX] Nagivation refresh widget
@oca-travis @anusriNPS
[UPD] Update attachment_preview.pot
290c389
@sysadminmatmoz @anusriNPS
Translated using Weblate (Slovenian)
1bf8179 
Currently translated at 100.0% (2 of 2 strings)

Translation: knowledge-12.0/knowledge-12.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/sl/
@oca-transbot @anusriNPS
Update translation files
6ef6feb 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-12.0/knowledge-12.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/
@khaeusler @anusriNPS
fix the visibility of the preview area
d1bdde5
@marcelsavegnago @anusriNPS
Added translation using Weblate (Portuguese (Brazil))
8d8ebf7
@hbrunn @anusriNPS
[FIX] attachment_preview: start needs to return a promise
7369927
@yavuzavci @anusriNPS
Added translation using Weblate (Turkish)
57ef68f
@vancouver29 @anusriNPS
[IMP] attachment_preview: black, isort, prettier
1ee243d
@vancouver29 @anusriNPS
[MIG] attachment_preview: Migration to 15.0
e3debed
@vancouver29 @anusriNPS
[IMP] attachment_preview: fix _onPreviewAttachment and remove class o…
ace9e3e 
…_attachment_preview
@anusriNPS
[UPD] Update attachment_preview.pot
ffa4ff9
@luis-ron @anusriNPS
Translated using Weblate (Spanish)
6b6a333 
Currently translated at 100.0% (4 of 4 strings)

Translation: knowledge-15.0/knowledge-15.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/es/
@mymage @anusriNPS
Translated using Weblate (Italian)
322ee99 
Currently translated at 100.0% (4 of 4 strings)

Translation: knowledge-15.0/knowledge-15.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/it/
@anusriNPS
[IMP] attachment_preview: pre-commit execution
3b9c5fd
@anusriNPS
[MIG] attachment_preview: Migration to 16.0
b7404e2
@anusriNPS anusriNPS force-pushed the 16.0-mig-attachment_preview branch from 226b097 to b7404e2 Compare January 2, 2025 11:06
@yibudak
Copy link

yibudak commented Jan 20, 2025

@anusriNPS what's the status of this PR?

@anusriNPS
Copy link
Author

anusriNPS commented Jan 20, 2025

I missed to look into the PR #434 which already has migrated the module. I have not yet tested in 16.0 version with these changes in order to verify split screen view for attachment preview.

Once tested, if any bugs identified I thought of making changes for the same.

@diggy128
Copy link

diggy128 commented Apr 27, 2025

Any chance to fix test coverage to go green?

@anusriNPS
Copy link
Author

anusriNPS commented Apr 28, 2025

Any chance to fix test coverage to go green?

Currently not working on this item, so not sure about fixing these issues for now due to other prioritzed activites

@github-actions
Copy link

github-actions bot commented Aug 31, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 31, 2025
@github-actions github-actions bot closed this Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.